Skip to content

Commit

Permalink
[5.2] MSTR-265: Add 'Default' option for the Ringback options (#504)
Browse files Browse the repository at this point in the history
  • Loading branch information
pcandia committed Sep 14, 2023
1 parent 41fdd52 commit 8158f8f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions i18n/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@
"headline": "Group Ringback Settings",
"dropdownLabel": "Ringback media:",
"silence": "Silence",
"default": "Default",
"defaultRingback": "Default Ringback",
"emptyUploadAlert": "Please select a file to upload",
"fileTooBigAlert": "You can not upload a file with a size exceeding 5MB",
Expand Down
3 changes: 3 additions & 0 deletions submodules/groups/groups.js
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,9 @@ define(function(require) {
};
}

if (_.isEmpty(selectedMedia)) {
delete ringGroupNode.data.ringback;
}
self.groupsUpdateCallflow(data.baseCallflow, function() {
self.groupsUpdate(data.group, function(updatedGroup) {
popup.dialog('close').remove();
Expand Down
1 change: 1 addition & 0 deletions submodules/groups/views/feature-ringback.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
<div>
<span>{{ i18n.groups.ringback.dropdownLabel }}</span>
<select name="format" class="media-dropdown">
<option value="" {{#compare media '===' ""}}selected{{/compare}}>{{ i18n.groups.ringback.default }}</option>
<option value="{{silenceMedia}}" {{#compare media '===' silenceMedia}}selected{{/compare}}>{{ i18n.groups.ringback.silence }}</option>
{{#each mediaList}}
<option value="{{this.id}}" {{#compare ../media '===' this.id}}selected{{/compare}}>{{this.name}}</option>
Expand Down

0 comments on commit 8158f8f

Please sign in to comment.