[5.3] MSTR-275: do not require sub module, let core handle it #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2023
guillegr123
previously approved these changes
Dec 16, 2023
If the app assets is loading from external `source_url`, if the app tries to require its
sub modules directly it will fail and the app won't load at all.
Changing the module name to its external `source_url` as what Monster UI core was
previously doing won't always work in case the sub modules were small enough and optimized
away in a single file as `app.js`. This has been observed with `branding` and
`call-recording` apps so far.
Instead we can explicitly config the paths for sub module and its external source url for
`requirejs` to load it, if it is not already optimized in the `app.js`.
Without this change, because `app.js` is requiring the submodules, this URL will be used
instead of external source_url:
```
http://{monster_ui_url}/apps/:appname/submodules/{submodule}/{submodule}.js
```
`requireSubModule` from `monster.apps.js` will require all submodules
defined on the app and can adds external `source_url` of the sub module in requirejs
config so the correct URL will be used for fetch if it is needed:
```
http://{app_metadata.source_url}/submodules/{submodule}/{submodule}.js
```
Read more: https://requirejs.org/docs/jquery.html#modulename
icehess
force-pushed
the
MSTR-275-5.3
branch
from
0cd15ac
to
834bc60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the app assets is loading from external
source_url, if the app tries to require its sub modules directly it will fail and the app won't load at all.Changing the module name to its external
source_urlas what Monster UI core was previously doing won't always work in case the sub modules were small enough and optimized away in a single file asapp.js. This has been observed withbrandingandcall-recordingapps so far.Instead we can explicitly config the paths for sub module and its external source url for
requirejsto load it, if it is not already optimized in theapp.js.Without this change, because
app.jsis requiring the submodules, this URL will be used instead of external source_url:requireSubModulefrommonster.apps.jswill require all submodules defined on the app and can adds externalsource_urlof the sub module in requirejs config so the correct URL will be used for fetch if it is needed:Read more: https://requirejs.org/docs/jquery.html#modulename