Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update #77

Merged
merged 3 commits into from
Mar 25, 2024
Merged

update #77

merged 3 commits into from
Mar 25, 2024

Conversation

feifei-111
Copy link
Collaborator

PR types

PR changes

Describe

tc20042008
tc20042008 reviewed Mar 24, 2024
View reviewed changes
paddle/cinn/frontend/group_cluster/pattern_graph.cc Outdated
std::unordered_set<PatternNode*> fusion_candidate = upstream->downstream_;
upstream->downstream_.clear();
for (const auto& downstream : fusion_candidate) {
PatternNode* new_node = new PatternNode(upstream, downstream);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要直接调用new。
一般而言，可以在Graph里添加std::vector<std::unqiue<T>> nodes，持有节点的生命周期。这样在析构函数里就不需要delete了。

tc20042008
tc20042008 reviewed Mar 24, 2024
View reviewed changes
paddle/cinn/frontend/group_cluster/pattern_base.h Outdated
struct TrivialPattern {
explicit TrivialPattern(const std::unordered_set<const pir::Operation*>& ops)
: ops_(ops) {}
std::unordered_set<const pir::Operation*> ops_;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些地方最好都换成std::vector，且及时排序和去重。
std::unordered_set不能保证融合结果的稳定性。

tc20042008
tc20042008 reviewed Mar 24, 2024
View reviewed changes
paddle/cinn/frontend/group_cluster/pattern_base.h Outdated
std::unordered_set<const pir::Operation*> ops_;
};

using StmtPattern =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

using ReduceBasedPattern = std::variant<TrivialPattern, ReducePattern>;
using StmtPattern = std::variant<ReduceBasedPattern, UnsupportPattern>

2742195759
2742195759 reviewed Mar 25, 2024
View reviewed changes
paddle/cinn/frontend/group_cluster/pattern_graph.cc Outdated
}

void PatternGraph::FuseReducePattern() {
// TODO(wuzhanfei) reduce fusion, similar with implement in backend
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation

@feifei-111 feifei-111 merged commit 4fce3e6 into 2742195759:cinn-trivalop-fuse Mar 25, 2024
2742195759 added a commit that referenced this pull request Mar 30, 2024
@2742195759 @tc20042008
@feifei-111 @jiahy0825 @Fridge003
[CINN / PIR] Cinn trivalop fuse (PaddlePaddle#62088)
fec0b3d 
* implement FuseFilteredStmtPatterns

* update

* split trivial op into a single file.

* fix compiler complaints

* rename StmtIter to StmtPtr

* declare group_pattern.InferShardableAxes

* refine signature of group_pattern.InferShardableAxes

* move group_pattern.InferShardableAxes to group_pattern_util.InferShardableAxes

* implement group_pattern_util.InferShardableAxes

* add group_pattern_util.InferShardableAxesFromSink

* ReversedInferShardableAxes support sinks

* update op lower

* support multiple sinks in group_pattern_util.InferShardableAxes

* update

* fix link error

* update

* remove FusionOp to OpList

* update

* update

* update

* update

* declare group_pattern_util.h

* fix compiler complains

* declare group_pattern_util.ClusteringHelper

* refine signature of group_pattern_util.ClusterIntoGroupPatternsFromOpList

* update op lowr

* add todo

* minor refine by group_pattern_util.OpSet

* update

* update

* update (#57)

* update

* update

* Cinn trivalop fuse (#58)

* fix

* refactor StmtFusionHelper by OpTopo

* Complete: CreateReduceExpr function.

* update

* recursive done.

* update

* Cinn trivalop fuse (#59)

* clean all the TODO.

* update

* fix cluster

* remove unused OpTopo.downstream_disconnected_ops

* Cinn trivalop fuse (#60)

* fix compile rror

* update

* Cinn trivalop fuse (#61)

* add R + T skeleon

* add search utils.

* update

* Cinn trivalop fuse (#62)

* push

* update

* fix

* fix transformer

* fix

* Implement iterator vars fetching in ReduceOp

* small fix

* add GetOuterIterVars API

* fix

* fix compile complain

* modify GetOutputIters of TrivialOp

* remove dumplicate code in visit

* implement ClusterIntoGroupPatternsFromOpList

* Fix most error in trivial_op.cc.

* CreateReduceExpr is OK!

* fix

* add CheckIterEq

* implement group_pattern_util.ClusteringEngine and groupp_pattern_util.ClusteringPolicy

* SinkTrivialTransform OK!

* update

* fix init_tensor name problem.

* update

* fix compiler complains

* refactor ShardableAxesSignature by group_pattern.SoleOutputShardableAxes

* split trivial_op.cc

* update

* implement group_pattern_util.MakeShardableAxesSignature4ReduceOp

* update

* implement group_pattern_util.MakeEmptyShardableAxesSignature

* add helper class group_pattern_util.ShardableAxesProvider

* implement group_pattern_util.MakeShardableAxesSignature4BroadcastOp

* update

* update

* fix softmax error.!

* fix

* update

* merge

* fix

* Implement new OpMergeWithOp and add a relevant flag

* update

* update

* fix reduce_load error. add splitReduceTransform

* fix conflict

* update

* update

* update

* disable horizontal fusion

* fix

* Add some VLOG

* Fix group cluster bug (#71)

* fix

* fix dyshape

* fix

* init split cluster files

* update

* update

* update

* spliting

* update

* spliting

* spliting

* pattern utils

* update

* update

* clean cmake

* update

* update

* update

* fix clustering_engine

* fix fusion_helper

* update

* fix

* update

* update

* update

* update

* fix

* fix some erros

* update

* update

* fix split with num problem

* update

* fix

* fix static issues

* fix

* init split cluster files (#72)

* update

* update

* update

* update

* update

* update

* update

* update

* update

* split shardable axes provider (#73)

* update

* update

* fix broadcast (#75)

* update

* update

* fix

* fix code format

* fix code format

* remove unittest

* update

* update (#77)

* update

* update

* update

---------

Co-authored-by: tc20042008 <156998525+tc20042008@users.noreply.github.com>
Co-authored-by: feifei-111 <2364819892@qq.com>
Co-authored-by: jiahy0825 <jiahongyu@baidu.com>
Co-authored-by: zhangbaizhou <zhangbaizhou@baidu.com>
Co-authored-by: Baizhou Zhang <eddiezhang@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2742195759 2742195759 2742195759 left review comments

@tc20042008 tc20042008 tc20042008 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feifei-111 @2742195759 @tc20042008