Make toStringTag writable

Spec change: tc39/proposal-iterator-helpers#214
2767mr · Sep 19, 2022 · 8e5fe59 · 8e5fe59
1 parent 312fc2c
commit 8e5fe59
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/...e.js.test/src/com/oracle/truffle/js/test/builtins/AsyncIteratorPrototypeBuiltinsTest.java b/...e.js.test/src/com/oracle/truffle/js/test/builtins/AsyncIteratorPrototypeBuiltinsTest.java
@@ -511,6 +511,9 @@ public void testToString() {
         try (Context context = builder.build()) {
             Value result = context.eval(JavaScriptLanguage.ID, "AsyncIterator.prototype[Symbol.toStringTag]");
             Assert.assertEquals("Async Iterator", result.asString());
+
+            result = context.eval(JavaScriptLanguage.ID, "AsyncIterator.prototype[Symbol.toStringTag] = 'Changed'; AsyncIterator.prototype[Symbol.toStringTag]");
+            Assert.assertEquals("Changed", result.asString());
         }
     }
 

diff --git a/...ruffle.js.test/src/com/oracle/truffle/js/test/builtins/IteratorPrototypeBuiltinsTest.java b/...ruffle.js.test/src/com/oracle/truffle/js/test/builtins/IteratorPrototypeBuiltinsTest.java
@@ -605,6 +605,9 @@ public void testToString() {
         try (Context context = builder.build()) {
             Value result = context.eval(JavaScriptLanguage.ID, "Iterator.prototype[Symbol.toStringTag]");
             Assert.assertEquals("Iterator", result.asString());
+
+            result = context.eval(JavaScriptLanguage.ID, "Iterator.prototype[Symbol.toStringTag] = 'Changed'; Iterator.prototype[Symbol.toStringTag]");
+            Assert.assertEquals("Changed", result.asString());
         }
     }
 

diff --git a/...src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/builtins/JSAsyncIterator.java b/...src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/builtins/JSAsyncIterator.java
@@ -77,7 +77,7 @@ public JSDynamicObject createPrototype(JSRealm realm, JSFunctionObject ctor) {
 
         JSObjectUtil.putConstructorProperty(ctx, iteratorPrototype, ctor);
         JSObjectUtil.putFunctionsFromContainer(realm, iteratorPrototype, AsyncIteratorPrototypeBuiltins.BUILTINS);
-        JSObjectUtil.putToStringTag(iteratorPrototype, TO_STRING_NAME);
+        JSObjectUtil.putDataProperty(iteratorPrototype, Symbol.SYMBOL_TO_STRING_TAG, TO_STRING_NAME, JSAttributes.getDefaultNotEnumerable());
         JSObjectUtil.putDataProperty(realm.getContext(), iteratorPrototype, Symbol.SYMBOL_ASYNC_ITERATOR, createIteratorPrototypeSymbolIteratorFunction(realm), JSAttributes.getDefaultNotEnumerable());
 
         return iteratorPrototype;

diff --git a/...l-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/builtins/JSIterator.java b/...l-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/builtins/JSIterator.java
@@ -76,7 +76,7 @@ public JSDynamicObject createPrototype(JSRealm realm, JSFunctionObject ctor) {
 
         JSObjectUtil.putConstructorProperty(ctx, iteratorPrototype, ctor);
         JSObjectUtil.putFunctionsFromContainer(realm, iteratorPrototype, IteratorPrototypeBuiltins.BUILTINS);
-        JSObjectUtil.putToStringTag(iteratorPrototype, CLASS_NAME);
+        JSObjectUtil.putDataProperty(iteratorPrototype, Symbol.SYMBOL_TO_STRING_TAG, CLASS_NAME, JSAttributes.getDefaultNotEnumerable());
         JSObjectUtil.putDataProperty(realm.getContext(), iteratorPrototype, Symbol.SYMBOL_ITERATOR, createIteratorPrototypeSymbolIteratorFunction(realm), JSAttributes.getDefaultNotEnumerable());
 
         return iteratorPrototype;