-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix #4253
matrix #4253
Conversation
I think you made the script too complicated. |
libhysteria2's script is a standalone one. |
Sorry? |
I'll specific the ABI in its command parameter instead. Better to do this for libtun2socks too. |
The universal APK will not be built or uploaded at all now. |
It can still be built locally, if no gradlew parameter was provided. |
The |
They will compile all ABIs, just like before if no parameter was provided.
I don't think so, considering that bug is preventing it from being reproducible. And, building different ABIs in parallel will probably save some time.
OK. |
OK, you're right at build.gradle.kts. I just reviewed that and got to know I don't need to change it at all. |
I'll report this to Gradle instead. |
Maybe you have misunderstood? It's unnecessary to change build.gradle, but the matrix is necessary... I suggest you to fix it here...the bug reporting system of AGP seems horrible. |
There is no misunderstood. |
Well, the god dammit… that bug is not only limited to universal, it eventually chooses a same one for all ABIs. For example, it uses the versionCode of armeabi-v7a for itself and all other 3 ones. |
See:
The bug is like this:
When the filter contains than one ABI, all APK's some .dex files will get a same versionCode, their AndroidManifest.xml get the correct and according one though.