Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make providing container registry credentials easy via the helm chart #24

Closed
consideRatio opened this issue Apr 28, 2023 · 2 comments
Closed
Assignees

Comments

@consideRatio
Copy link
Contributor

BinderHub spawns Build pods that communicates with the docker-api setup on the k8s node's, and they need to pass credentials to push to an external container registry. So, for this to work, BinderHub starts these pods up to mount a k8s Secret with a docker client config file including credentials.

  1. A person installing the chart should be able to provide server / username / password to a container registry and have BinderHub spawned build pods able to push to it.
    I've not got the option to work out, such as kubectl create secret docker-registry <name> --docker-server=... and then reference that k8s Secret.
  2. We should support re-using previously provided credentials
    This makes someone do initial setup with helm install --set ... and then not need to retain the sensitive credentials in a git repo etc. We do this for a lot of z2jh credentials already for example.
  3. We should support having these credentials cleaned up when the helm release is deleted
    This comes out of the box by managing the k8s Secret we create via the Helm chart
@consideRatio consideRatio moved this to In Progress in BinderHub-JupyterHub Apr 28, 2023
@consideRatio consideRatio moved this to In Progress ⚡ in Sprint Board Apr 28, 2023
@consideRatio consideRatio self-assigned this Apr 28, 2023
@github-project-automation github-project-automation bot moved this to Needs Shaping / Refinement in DEPRECATED Engineering and Product Backlog May 3, 2023
@damianavila damianavila moved this from Needs Shaping / Refinement to In progress in DEPRECATED Engineering and Product Backlog May 3, 2023
@damianavila damianavila moved this from In progress to Ready to work in DEPRECATED Engineering and Product Backlog Jul 5, 2023
@damianavila damianavila moved this from In Progress to Todo in BinderHub-JupyterHub Aug 1, 2023
@damianavila damianavila moved this from Todo to In Progress in BinderHub-JupyterHub Aug 1, 2023
@damianavila damianavila moved this from Ready to work to In progress in DEPRECATED Engineering and Product Backlog Aug 1, 2023
@damianavila
Copy link

@consideRatio, this is fixed by #36, right?

@consideRatio
Copy link
Contributor Author

@damianavila yes thanks thats correct!

@github-project-automation github-project-automation bot moved this from In Progress to Done in BinderHub-JupyterHub Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants