-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to pass docker config and included registry credentials to build pods' docker clients, test builds and pushes, and add dockerApi.[extraArgs|extraFiles] to help testing #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/mash-backup
branch
4 times, most recently
from
June 5, 2023 11:51
1776567
to
c6f542a
Compare
consideRatio
force-pushed
the
pr/mash-backup
branch
from
July 8, 2023 15:54
c6f542a
to
5946aca
Compare
consideRatio
changed the title
Add ability to pass registry credentials to build pods' docker clients
Add ability to pass docker config and included registry credentials to build pods' docker clients
Jul 8, 2023
consideRatio
force-pushed
the
pr/mash-backup
branch
from
July 8, 2023 16:52
fb25cdd
to
6d7b84e
Compare
consideRatio
force-pushed
the
pr/mash-backup
branch
from
July 8, 2023 16:55
6d7b84e
to
b21ee11
Compare
consideRatio
force-pushed
the
pr/mash-backup
branch
3 times, most recently
from
July 8, 2023 17:54
621c919
to
ce1f141
Compare
consideRatio
force-pushed
the
pr/mash-backup
branch
3 times, most recently
from
July 8, 2023 19:45
c9fb963
to
00a549e
Compare
consideRatio
force-pushed
the
pr/mash-backup
branch
from
July 8, 2023 19:46
00a549e
to
c17753c
Compare
consideRatio
changed the title
Add ability to pass docker config and included registry credentials to build pods' docker clients
Add ability to pass docker config and included registry credentials to build pods' docker clients, test builds and pushes, and add dockerApi.[extraArgs|extraFiles] to help testing
Jul 8, 2023
@GeorgianaElena I think this is good to go finally, its quite a messy PR because it introduced dockerApi.extraFiles for example, but that is copy-pasted from z2jh where it has been very successfully used reliably to inject files into pods. I suggest we go for a merge and iterating from there with fixes if needed. |
Thanks @consideRatio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With binderhub-service being a Helm chart deploying to k8s, we absolutely require the ability to push the built artifact to a container registry somewhere. This enables the chart to create a k8s Secret with such credentials in a docker config format that can be mounted to the build pods via
c.KubernetesBuildExecutor.push_secret
. Users of the binderhub-service chart doesn't have to configure that manually, its instead set automatically.buildPodsRegistryCredentials
buildPodsRegistryCredentials
should be provided withserver
,username
, andpassword
for the container registry. For a GCP based artifact-registry, this can be for example...buildPodsDockerConfig
This may not be relevant for us to use, but was added for parity with binderhub chart to some degree.
dockerApi.[extraArgs|extraFiles]
In order to setup tests with build/push, I needed to configure the docker daemon runnin on the host node to tolerate interacting with HTTP based docker registries like the one we have. Instead of doing like in jupyterhub/binderhub where a configmap is created and mounted etc in a way that is very hard to follow, I do something that is just quite hard to follow by introducing
extraFiles
taken from z2jh.Tests build/push