Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve our tests to also trigger a build and push to a registry #26

Closed
1 of 2 tasks
consideRatio opened this issue Apr 28, 2023 · 0 comments · Fixed by #36
Closed
1 of 2 tasks

ci: improve our tests to also trigger a build and push to a registry #26

consideRatio opened this issue Apr 28, 2023 · 0 comments · Fixed by #36
Assignees
Labels

Comments

@consideRatio
Copy link
Contributor

consideRatio commented Apr 28, 2023

We have automation setup that test installs the helm chart and ensures pods enter a running state successfully. We should do a bit more.

  • Setup a container registry, and grant permissions to k3s that is setup by jupyterhub/action-k3s-helm to pull from it (something like this)
  • Make chartpress push images to the container registry as well (something like this)

I think we can be inspired by binderhub's strategies, but that we should aim for a lower complexity:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Archived in project
1 participant