-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info on granting 2i2c GCP access #67
Conversation
2. Give 2i2c [billing administrator](https://cloud.google.com/billing/docs/how-to/billing-access) | ||
permissions. You can do this by: | ||
|
||
1. Going to 'Account Management' on the left menu inside your billing account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuvipanda, do you think adding screenshots will make sense here? I highly appreciate instructions that provide screenshots because I can double check that I'm the right place.
If the menu is super obvious, please ignore the noise :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree that screenshots would help - though probably don't need to be a blocker for the PR if Yuvi would just like to get something in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree re: screenshots. I don't want to block this PR for screenshots tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few quick comments - in general this looks great! I think we should prioritize merging this relatively quickly so that others can go through the steps and give feedback, and keeping track of improvements to make (e.g., images) in the goal issue. WDYT?
'Billing -> Billing Accounts User'. The full administrator role is | ||
preferred. | ||
``` | ||
5. Enter the following user emails under 'New members': `yuvipanda@2i2c.org`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there some way that we can provision a generic account that will work here? e.g., billing@2i2c.org
or something?
2. Give 2i2c [billing administrator](https://cloud.google.com/billing/docs/how-to/billing-access) | ||
permissions. You can do this by: | ||
|
||
1. Going to 'Account Management' on the left menu inside your billing account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree that screenshots would help - though probably don't need to be a blocker for the PR if Yuvi would just like to get something in
|
||
A GCP [billing account](https://cloud.google.com/billing/docs/how-to/manage-billing-account) | ||
is attached to a source of funds (Credit Card, Institutional account with invoicing, | ||
credits provided by Google, etc). Giving 2i2c full access to a billing account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the "Giving 2i2c full access..." content should be in a standalone section at the top, since it is more like an "explanation about billing" rather than a step in a how-to (also is provider-agnostic, right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to write it in provider generic way just now, but I couldn't figure out how - 'billing account' and 'project' are GCP specific. AWS and Azure have other mechanisms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - let’s just leave it as is for now
help manage your project. | ||
6. Click 'Save'. This sends 2i2c staff an invitation to your billing account. | ||
|
||
Let 2i2c staff know once you've completed this process, and they should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should give them a more specific instruction. Assuming that we have got an issue open per hub, maybe we should tell them to ping us on that issue? (and we should build into the template for hub issues whether we need them to provision an account)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense. I'm not sure of the exact mechanism here though. Shall we open an issue for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let’s add this to a goal, don’t we have a goal for something like “define communication pathways for champions”?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened 2i2c-org/infrastructure#306 (comment) for it.
3. Select 'Projects -> Owner' as the role. This gives 2i2c full rights to | ||
everything inside the project. | ||
|
||
4. Enter the following user emails under 'New members': `yuvipanda@2i2c.org`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here re: generic email? Since this one is the project maybe it should be something like sre@2i2c.org
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that this gets an invite associated with a google account, so it would need to be sent to each individual user who needs access - I think emails like that are aliases? If we want to, we can create a google account called sre@2i2c.org and invite things there. Then that account will need to log-in to google cloud, and grant other users login access. I'd like to avoid that if we can at least for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good - I’m mostly just trying to minimize the potential bottleneck here. Do we run the risk one person wanting to do something but not being able to because they weren’t given the right permissions to a billing account?
I think that we are good to merge and keep track of remaining todos in the goals. Do you agree? |
I created notes in 2i2c-org/infrastructure#306 (comment) to track feedback here. I think this is ready to merge, @choldgraf |
Ref 2i2c-org/infrastructure#306