Skip to content

Commit

Permalink
Default dask nodes to be same config as notebook nodes in azure
Browse files Browse the repository at this point in the history
The documentation said this is what already happens, but
the documentation was a lie.

This helps us keep config simple and easy to manage.
  • Loading branch information
yuvipanda committed Nov 15, 2021
1 parent 6cf0a3f commit 9368b77
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 3 additions & 1 deletion terraform/azure/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ resource "azurerm_kubernetes_cluster_node_pool" "user_pool" {
}

resource "azurerm_kubernetes_cluster_node_pool" "dask_pool" {
for_each = var.dask_nodes
# If dask_nodes is set, we use that. If it isn't, we use notebook_nodes.
# This lets us set dask_nodes to an empty array to get no dask nodes
for_each = try(var.dask_nodes, var.notebook_nodes)

name = "dask${each.key}"
kubernetes_cluster_id = azurerm_kubernetes_cluster.jupyterhub.id
Expand Down
3 changes: 3 additions & 0 deletions terraform/azure/projects/justiceinnovationlab.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,6 @@ notebook_nodes = {
vm_size : "Standard_E32s_v4"
},
}

# JIL doesn't use dask-gateway
dask_nodes = {}

0 comments on commit 9368b77

Please sign in to comment.