Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate EFS creation for AWS #622

Closed
1 of 2 tasks
Tracked by #737
yuvipanda opened this issue Aug 23, 2021 · 7 comments
Closed
1 of 2 tasks
Tracked by #737

Automate EFS creation for AWS #622

yuvipanda opened this issue Aug 23, 2021 · 7 comments
Labels
Task Actions that don't involve changing our code or docs.

Comments

@yuvipanda
Copy link
Member

yuvipanda commented Aug 23, 2021

Description

We use EFS for home directory storage on AWS, and it works really well. We have a script to set it up for use with kops (https://github.com/2i2c-org/pilot-hubs/blob/master/kops/setup-efs.py) but not with eksctl. It should be a fully automatically set up, ideally with terraform.

Benefit

This is another step in automating our deployment infrastructure so that we can deploy new hubs with less complexity and new steps. It also further professionalizes our infrastructure to be more reliable and consistent.

Implementation

This should be an addition to the AWS Terraform code.

We have a kops implementation of this here: https://github.com/2i2c-org/pilot-hubs/blob/master/kops/setup-efs.py

But we should use eksctl instead if possible.

Tasks

@yuvipanda yuvipanda added the Task Actions that don't involve changing our code or docs. label Aug 23, 2021
@choldgraf
Copy link
Member

@yuvipanda I was trying to clean this one up a little bit, and I'm not actually sure what is needed to make this happen. The original issue said that this should be done with Terraform, but I don't see any AWS terraform in our terraform folder.

Does implementing this issue require also implementing AWS terraform deployment code in general?

@yuvipanda
Copy link
Member Author

Does implementing this issue require also implementing AWS terraform deployment code in general?

yep!

@choldgraf
Copy link
Member

choldgraf commented Jan 4, 2022

I believe that this and #623 is now completed? ref: https://github.com/2i2c-org/infrastructure/blob/master/terraform/aws/efs.tf

@yuvipanda
Copy link
Member Author

Yep!

@damianavila
Copy link
Contributor

I do not think #623 is actually completed, right? When I look into the terraform code, I do not see any references to the backup and I think that does not come by default...
I do not see the issue closed but it seems @choldgraf wanted to close it.

@choldgraf
Copy link
Member

@damianavila I was just trying to clean up issues that I thought were dangling and that had already been resolved. If this hasn't been addressed, we should decide how important #623 is and whether we should prioritize it. What do you think?

@damianavila
Copy link
Contributor

we should decide how important #623 is and whether we should prioritize it. What do you think?

Yep, let's continue the conversation in #623.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Actions that don't involve changing our code or docs.
Projects
None yet
Development

No branches or pull requests

3 participants