-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version of dask-gateway helm chart we use to 0.9.1 or higher #745
Comments
Is there any downside to bumping it? Breaking changes, etc? If not, then I am +1 in any case, because I'm a fan of keeping our deps updated to the latest releases as a general rule. |
@sgibson91 do you have more details on why this is not needed anymore in 0.9.1 or higher? |
Ping @consideRatio since he is pretty confident in this |
Yes, its fixed in unreleased dask-gateway helm chart by a PR of me, i added a label to a pod in that pr. No release has been made since. On mobile, cant find link atm. |
I believe it is this PR dask/dask-gateway#352 Seems like it is blocked on a release |
Thanks for the links folks, the bumping idea LGTM when the dask-gateway helm chart containing this fix is released. |
So if I understand correctly, it seems like these are our next tasks on this one:
|
And take care of this one, right? |
Yes I believe so! |
ok cool - I updated the top comment with the new list :-) |
Is there anything we can do to help dask-gateway make a release? I think I recall @consideRatio mentioning that the new dev team that are taking over are a little bit nervous of the release process or something along those lines? |
Perhaps you can show interest in dask/dask-gateway#381? I don't think there is technical work blocking that we are aware of and could act on. |
Definitely bumped up now, thanks to @consideRatio for making the releases! |
Description
In #743 I add a comment to the daskhub values file pointing out that disabling network policies that target the hub pod is a hack to allow us to use the dask-gateway helm chart. However, that hack is no longer required if we bump the version of dask-gateway to version 0.9.1 or higher.
Value / benefit
Implementation details
No response
Tasks to complete
Updates
No response
The text was updated successfully, but these errors were encountered: