Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of dask-gateway helm chart we use to 0.9.1 or higher #745

Closed
1 of 4 tasks
sgibson91 opened this issue Oct 7, 2021 · 13 comments
Closed
1 of 4 tasks

Bump version of dask-gateway helm chart we use to 0.9.1 or higher #745

sgibson91 opened this issue Oct 7, 2021 · 13 comments
Assignees

Comments

@sgibson91
Copy link
Member

sgibson91 commented Oct 7, 2021

Description

In #743 I add a comment to the daskhub values file pointing out that disabling network policies that target the hub pod is a hack to allow us to use the dask-gateway helm chart. However, that hack is no longer required if we bump the version of dask-gateway to version 0.9.1 or higher.

Value / benefit

  • Config without workarounds/hacks is a step towards a robust and reliable service :)

Implementation details

No response

Tasks to complete

Updates

No response

@choldgraf
Copy link
Member

Is there any downside to bumping it? Breaking changes, etc?

If not, then I am +1 in any case, because I'm a fan of keeping our deps updated to the latest releases as a general rule.

@damianavila
Copy link
Contributor

@sgibson91 do you have more details on why this is not needed anymore in 0.9.1 or higher?

@sgibson91
Copy link
Member Author

@sgibson91 do you have more details on why this is not needed anymore in 0.9.1 or higher?

Ping @consideRatio since he is pretty confident in this

@consideRatio
Copy link
Contributor

Yes, its fixed in unreleased dask-gateway helm chart by a PR of me, i added a label to a pod in that pr. No release has been made since.

On mobile, cant find link atm.

@sgibson91
Copy link
Member Author

sgibson91 commented Oct 8, 2021

I believe it is this PR dask/dask-gateway#352 Seems like it is blocked on a release

@damianavila
Copy link
Contributor

Thanks for the links folks, the bumping idea LGTM when the dask-gateway helm chart containing this fix is released.

@choldgraf
Copy link
Member

choldgraf commented Oct 8, 2021

So if I understand correctly, it seems like these are our next tasks on this one:

@damianavila
Copy link
Contributor

damianavila commented Oct 9, 2021

And take care of this one, right?

@sgibson91
Copy link
Member Author

And take care of this one, right?

Yes I believe so!

@choldgraf
Copy link
Member

ok cool - I updated the top comment with the new list :-)

@sgibson91
Copy link
Member Author

Is there anything we can do to help dask-gateway make a release? I think I recall @consideRatio mentioning that the new dev team that are taking over are a little bit nervous of the release process or something along those lines?

@consideRatio
Copy link
Contributor

Perhaps you can show interest in dask/dask-gateway#381?

I don't think there is technical work blocking that we are aware of and could act on.

@yuvipanda
Copy link
Member

Definitely bumped up now, thanks to @consideRatio for making the releases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

5 participants