Use dask-gateway 2022.10.0 and rely on mounted api-token from jupyterhub chart, also revert the workaround removing the hub NetworkPolicy #1769
Conversation
consideRatio
requested review from
yuvipanda and
sgibson91
and removed request for
yuvipanda
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
consideRatio
changed the title
|
Thanks @consideRatio. The one question I have is - does this require upgrade to dask-gateway version in the user image? Thank you for doing the PR, I think once I've an answer to that we can figure out next steps. |
|
No need to update the dask-gateway client in the user images, the chart can be updated first by itself! |
|
Thanks, @consideRatio! |
|
Hey everyone, will this change allow me to use dask/distributed#7128 (reply in thread) on the LEAP hub?? I'm itching to try out some of these changes 🙏 |
|
Same here, when will this be visible on the m2lines hub? |
|
@TomNicholas @dhruvbalwada let me deploy this on m2lines, and you can test it out, and if that works ok i can roll it out everywhere? |
|
Note that the conda-forge release of the dask-gateway client, that includes some bugfixes etc, isn't yet released. Besides that, I'm not sure if there should be any notable difference for users of the old installation vs the new. https://gateway.dask.org/changelog.html When a PR is opened to https://github.com/conda-forge/dask-gateway-feedstock/pulls I'll quickly get the dask-gateway client 2022.10.0 released as well. @TomNicholas and @dhruvbalwada I suspect you need to ensure that you use a modern version of |
|
Actually, since m2lines still has the new GPU stuff deployed but not merged yet, I've deployed this to leap.2i2c.cloud. @TomNicholas and @dhruvbalwada can you try it out and let me know if it works fine? |
|
I don't have access to the leap cloud. Who do I ask to get access to that? |
|
@dhruvbalwada ah i'm not sure actually. I've just deployed this on m2lines too now, so test it out there. It's no longer deployed on LEAP |
|
I don't see it yet, I still see the dask version to be |
…hub chart Relies on dask/dask-gateway#612 released in 2022.10.0 so we don't have to set this explicitly.
yuvipanda
force-pushed
the
pr/update-to-dg-2022.10.0-and-remove-apitoken-stuff
branch
from
fcc2fc0 to
9e5ed2e
Compare
Brings in newer dask client version
|
@dhruvbalwada try now? You might have to start and stop your server. |
|
I just looked on the LEAP hub but only see |
|
@TomNicholas try again now? You might have to start / stop your server. |
|
Dask-gateway is just what helps start dask workers. I think its entirely unrelated to dask itself, distributed, and other dask software releases. |
|
@consideRatio yep! To help these folks test, I've augmented this PR with an image bump that also increases the dask version in the images. |
|
I still don't see it on the LEAP hub - I'm logging on, starting a terminal and typing |
|
I see the 2022.9.2 on m2lines hub now. |
|
Oh scratch that I see 2022.9.2 on LEAP now too! |
|
BTW I'm now seeing this bug with dask-gateway when I try and display by client widget dask/dask-gateway#607 I think to fix it we need dask-gateway=2022.10.0, but we have 2022.6.1 currently. EDIT: Is dask-gateway something I can change the version of just in my environment/notebook myself safely? I thought I couldn't change distributed at least. |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/3268661520 |
|
@TomNicholas I've opened conda-forge/pangeo-dask-feedstock#97 to bump the version in the image itself. However, the infrastructure is up to the latest dask-gateway now! Thanks a lot, @consideRatio! |
Brings in pangeo-data/pangeo-docker-images#395, which brings in conda-forge/pangeo-dask-feedstock#96, which brings in newer versions of dask and dask-gateway. Follow-up to 2i2c-org#1769
Brings in pangeo-data/pangeo-docker-images#395, which brings in conda-forge/pangeo-dask-feedstock#96, which brings in newer versions of dask and dask-gateway. Follow-up to 2i2c-org#1769
|
@TomNicholas @dhruvbalwada ok, the image updates have come through now and this is what I see:
(pasting an image as JupyterLab terminal doesn't want me to copy from it?! WT><CJKHlkhga). Anyway, let me know if things work now? |
|
Works. |
Relies on dask/dask-gateway#612 released in 2022.10.0 so we don't have to set this explicitly.
While I've tested this in the JMTE hub. I've not tested the adjustments I've made to the binderhub chart that includes another dask-gateway installation. I made the changes I think is required for it though and think it should work fine there as well.
I'd be thankful if someone else can go for a merge of this and ensure that things work in all the 2i2c hubs. I opted to go for a PR as that felt like a clear way of documenting what I thought should be done to resolve #1754.