Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all hubs: remove unused config jupyterhub.proxy.hosts #2585

Merged

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented May 29, 2023

I think the jupyterhub.proxy.hosts config is only relevant to the jupyterhub chart if its involved in handling TLS/HTTPS matters, but we let this be done before the jupyterhub chart gets involved (by nginx-ingress controller and cert-manager acting based on provided Ingress resource).

As part of this PR, I also removed two or three hubs configured with jupyterhub.proxy.https=False explicitly, which is the default in the jupyterhub chart anyhow but has been needed historically.

Related

@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws openscapes No Yes Core infrastructure has been modified
kubeconfig utoronto No Yes Core infrastructure has been modified
gcp 2i2c No Yes Core infrastructure has been modified
gcp callysto No Yes Core infrastructure has been modified
aws victor No Yes Core infrastructure has been modified
gcp cloudbank No Yes Core infrastructure has been modified
aws carbonplan No Yes Core infrastructure has been modified
gcp pangeo-hubs No Yes Core infrastructure has been modified
aws gridsst No Yes Core infrastructure has been modified
aws jupyter-meets-the-earth No Yes Core infrastructure has been modified
gcp qcl No Yes Core infrastructure has been modified
aws ubc-eoas No Yes Core infrastructure has been modified
gcp meom-ige No Yes Core infrastructure has been modified
gcp m2lines No Yes Core infrastructure has been modified
gcp leap No Yes Core infrastructure has been modified
gcp linked-earth No Yes Core infrastructure has been modified
aws nasa-cryo No Yes Core infrastructure has been modified
gcp 2i2c-uk No Yes Core infrastructure has been modified
gcp awi-ciroh No Yes Core infrastructure has been modified
aws smithsonian No Yes Core infrastructure has been modified
aws nasa-veda No Yes Core infrastructure has been modified
aws 2i2c-aws-us No Yes Core infrastructure has been modified

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws openscapes prod Core infrastructure has been modified
kubeconfig utoronto prod Core infrastructure has been modified
kubeconfig utoronto r-prod Core infrastructure has been modified
gcp 2i2c hackanexoplanet Core infrastructure has been modified
gcp 2i2c demo Core infrastructure has been modified
gcp 2i2c ohw Core infrastructure has been modified
gcp 2i2c pfw Core infrastructure has been modified
gcp 2i2c peddie Core infrastructure has been modified
gcp 2i2c catalyst-cooperative Core infrastructure has been modified
gcp 2i2c earthlab Core infrastructure has been modified
gcp 2i2c aup Core infrastructure has been modified
gcp 2i2c temple Core infrastructure has been modified
gcp 2i2c ucmerced Core infrastructure has been modified
gcp 2i2c cosmicds Core infrastructure has been modified
gcp callysto prod Core infrastructure has been modified
aws victor prod Core infrastructure has been modified
gcp cloudbank ccsf Core infrastructure has been modified
gcp cloudbank csm Core infrastructure has been modified
gcp cloudbank elcamino Core infrastructure has been modified
gcp cloudbank glendale Core infrastructure has been modified
gcp cloudbank howard Core infrastructure has been modified
gcp cloudbank miracosta Core infrastructure has been modified
gcp cloudbank skyline Core infrastructure has been modified
gcp cloudbank demo Core infrastructure has been modified
gcp cloudbank fresno Core infrastructure has been modified
gcp cloudbank laney Core infrastructure has been modified
gcp cloudbank lassen Core infrastructure has been modified
gcp cloudbank sbcc Core infrastructure has been modified
gcp cloudbank lacc Core infrastructure has been modified
gcp cloudbank mills Core infrastructure has been modified
gcp cloudbank palomar Core infrastructure has been modified
gcp cloudbank pasadena Core infrastructure has been modified
gcp cloudbank sjcc Core infrastructure has been modified
gcp cloudbank tuskegee Core infrastructure has been modified
gcp cloudbank avc Core infrastructure has been modified
gcp cloudbank csu Core infrastructure has been modified
aws carbonplan prod Core infrastructure has been modified
gcp pangeo-hubs prod Core infrastructure has been modified
aws gridsst prod Core infrastructure has been modified
aws jupyter-meets-the-earth prod Core infrastructure has been modified
gcp qcl prod Core infrastructure has been modified
aws ubc-eoas prod Core infrastructure has been modified
gcp meom-ige prod Core infrastructure has been modified
gcp m2lines prod Core infrastructure has been modified
gcp leap prod Core infrastructure has been modified
gcp linked-earth prod Core infrastructure has been modified
aws nasa-cryo prod Core infrastructure has been modified
gcp 2i2c-uk lis Core infrastructure has been modified
gcp awi-ciroh prod Core infrastructure has been modified
aws smithsonian prod Core infrastructure has been modified
aws nasa-veda prod Core infrastructure has been modified
aws 2i2c-aws-us researchdelight Core infrastructure has been modified
aws 2i2c-aws-us ncar-cisl Core infrastructure has been modified

@consideRatio consideRatio requested a review from a team May 29, 2023 10:00
@consideRatio consideRatio merged commit 13f915b into 2i2c-org:master May 29, 2023
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/5111348544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants