-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure hub template doc, update diagram and add more info #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, but text looks good! The image is empty?
In addition, I think we need to document https://github.com/2i2c-org/pilot-hubs/blob/master/hub.py#L356. If you're using daskhub or ephemeral hub, config in |
Co-authored-by: Yuvi Panda <yuvipanda@gmail.com>
It shouldn't be: https://github.com/GeorgianaElena/pilot-hubs/blob/docs/hub-templates/docs/images/config-flow.png
Yes! Ty! |
|
||
For example, the **ephemeral hub** is a special kind of hub that is built using the *ephemeral-hub template* | ||
and has the following features: | ||
```{figure} images/config-flow.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GeorgianaElena can you add a comment in these docs (with %
) that says where these images were created, and how a different team member could update them if they wanted to do so?
Ref: #274
Closes #162