Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump z2jh to v1.0 beta #439

Merged
merged 9 commits into from
Jun 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# Added by 2i2c
Chart.lock
**/charts/*.tgz

.env-*



# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]
Expand Down
7 changes: 3 additions & 4 deletions hub-templates/basehub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ apiVersion: v2
appVersion: '1.0'
description: Deployment Chart for JupyterHub
name: basehub
# Let's keep this constant so other charts in this repo can depend on this easily
version: 0.0.1-n769.hfd04ce8
version: "0.1.0"
dependencies:
- name: jupyterhub
# REMEMBER TO CHANGE BASE IMAGE OF images/hub/ WHEN CHANGING THIS
version: 0.11.1-n277.h61b0e003
# REMEMBER TO CHANGE BASE IMAGE OF images/hub/ WHEN CHANGING THIS
version: 1.0.0-beta.1
repository: https://jupyterhub.github.io/helm-chart/
6 changes: 0 additions & 6 deletions hub-templates/basehub/requirements.lock

This file was deleted.

25 changes: 12 additions & 13 deletions hub-templates/basehub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,15 @@ nfsPVC:

jupyterhub:
custom:
singleuserAdmin:
extraVolumeMounts:
- name: home
mountPath: /home/jovyan/shared-readwrite
subPath: _shared
cloudResources:
provider: null
provider:
GeorgianaElena marked this conversation as resolved.
Show resolved Hide resolved
gcp:
projectId: null
projectId:
scratchBucket:
enabled: false
ingress:
Expand Down Expand Up @@ -67,8 +72,6 @@ jupyterhub:
hook:
enabled: false
proxy:
https:
enabled: false
damianavila marked this conversation as resolved.
Show resolved Hide resolved
service:
type: ClusterIP
chp:
Expand All @@ -95,11 +98,6 @@ jupyterhub:
letsencrypt:
contactEmail: yuvipanda@gmail.com
singleuser:
admin:
extraVolumeMounts:
- name: home
mountPath: /home/jovyan/shared-readwrite
subPath: _shared
startTimeout: 600 # 10 mins, because sometimes we have too many new nodes coming up together
defaultUrl: /tree
nodeSelector:
Expand Down Expand Up @@ -161,7 +159,8 @@ jupyterhub:
interfaces:
- value: "/tree"
title: Classic Notebook
description: The original single-document interface for creating Jupyter Notebooks.
description: The original single-document interface for creating
Jupyter Notebooks.
- value: "/lab"
title: JupyterLab
description: A Powerful next generation notebook interface
Expand All @@ -179,7 +178,7 @@ jupyterhub:
- --Configurator.config_file=/usr/local/etc/jupyterhub-configurator/jupyterhub_configurator_config.py
image:
name: quay.io/2i2c/pilot-hub
tag: '0.0.1-n769.hfd04ce8'
tag: '0.0.1-n781.hf8d0498'
config:
JupyterHub:
authenticator_class: oauthenticator.auth0.Auth0OAuthenticator
Expand Down Expand Up @@ -256,7 +255,7 @@ jupyterhub:

class CustomSpawner(ConfiguratorSpawnerMixin, KubeSpawner):
def start(self, *args, **kwargs):
custom_admin = get_config('singleuser.admin', {})
custom_admin = get_config('custom.singleuserAdmin', {})
if custom_admin and self.user.admin:
extra_init_containers = custom_admin.get('initContainers', [])
extra_volume_mounts = custom_admin.get('extraVolumeMounts', [])
Expand Down Expand Up @@ -311,4 +310,4 @@ jupyterhub:
'PANGEO_SCRATCH': f'{bucket_protocol}://{bucket_name}/$(JUPYTERHUB_USER)',
}

c.KubeSpawner.environment.update(env)
c.KubeSpawner.environment.update(env)
9 changes: 0 additions & 9 deletions hub-templates/daskhub/Chart.lock

This file was deleted.

3 changes: 1 addition & 2 deletions hub-templates/daskhub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ apiVersion: v2
appVersion: '1.0'
description: Deployment Chart for a dask-enabled JupyterHub
name: daskhub
version: 0.0.1-n2724.h1dfae31
version: "0.1.0"
dependencies:
- name: basehub
version: 0.0.1
repository: file://../basehub
- name: dask-gateway
version: "0.9.0"
Expand Down
6 changes: 0 additions & 6 deletions hub-templates/daskhub/requirements.lock

This file was deleted.

1 change: 0 additions & 1 deletion hub-templates/daskhub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ basehub:
- port: 22
protocol: TCP
cloudMetadata:
enabled: true
damianavila marked this conversation as resolved.
Show resolved Hide resolved
# Don't block access to AWS cloud metadata
# If we don't, our users can't access S3 buckets / other AWS services
# without an explicit identity
Expand Down
2 changes: 1 addition & 1 deletion hub-templates/images/hub/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Should match the hub image used by version of chart in hub/requirements.yaml
# If that changes, this should be changed too!
FROM jupyterhub/k8s-hub:0.11.1-n298.hd9d7403b
FROM jupyterhub/k8s-hub:1.0.0-beta.1

ENV CONFIGURATOR_VERSION ed7e3a0df1e3d625d10903ef7d7fd9c2fbb548db

Expand Down
4 changes: 3 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
backoff
chartpress
six # temp workaround for docker==5.0.0, used by chartpress, that failed to depend on six
ruamel.yaml
auth0-python
jhub-client==0.1.2
jsonschema
jsonschema
34 changes: 29 additions & 5 deletions support/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,30 @@
apiVersion: v1
appVersion: '1.0'
description: Support chart for entire cluster
apiVersion: v2
name: support
# Let's keep this constant so other charts in this repo can depend on this easily
version: 0.0.1
version: "0.1.0"
description: Cluster wide depdencies for deployed hubs

dependencies:
# Prometheus for collection of metrics.
# https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus
- name: prometheus
version: 11.15.0
repository: https://prometheus-community.github.io/helm-charts

# Grafana for dashboarding of metrics.
# https://github.com/grafana/helm-charts/tree/main/charts/grafana
- name: grafana
version: 5.6.4
repository: https://grafana.github.io/helm-charts

# ingress-nginx for a k8s Ingress resource controller that routes traffic from
# a single IP entrypoint to various services exposed via k8s Ingress resources
# that references this controller.
- name: ingress-nginx
version: 2.15.0
repository: https://kubernetes.github.io/ingress-nginx

# cert-manager for acquisition of TLS certificates
# https://github.com/jetstack/cert-manager/tree/master/deploy/charts/cert-manager
- name: cert-manager
version: v1.0.0-beta.1
repository: https://charts.jetstack.io
11 changes: 11 additions & 0 deletions support/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
## FIXME: Describe this Helm chart

Describe more about this Helm chart. What are the assumptions made within it for
example, and what are the assumptions on basehub and daskhub with regards to
what is available within the k8s cluster. Do they rely on ingress-nginx and
cert-manager for example?

### Observations
- This Helm chart contains config specific to 2i2c k8s cluster, as noted by a
domain name configured for grafana.
- This Helm chart contain a template creating a GCP specific k8s StorageClass
13 changes: 0 additions & 13 deletions support/requirements.yaml

This file was deleted.