basehub chart: resource limits for binderhub-service build & docker-api pods #4416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
consideRatio
commented
Jul 11, 2024
Comment on lines
+59
to
+61
| # memory_request are currently zeroed based on discussion in: | ||
| # https://github.com/2i2c-org/infrastructure/issues/4371#issuecomment-2223168854 | ||
| memory_request: 0 # 1G in mybinder.org-deploy |
There was a problem hiding this comment.
The build pods aren't daemonset pods, so they won't cause as much trouble and could possibly have a request. They need to be scheduled on a node with a daemonset pod though, but it felt safer to just go 0 here to avoid complexity.
consideRatio
force-pushed
the
pr/dont-merge-update
branch
from
9c559e5
to
6a2c1ba
Compare
|
I don't really have much capacity to deeply review this, so I'll simply trust that your testing had gotten this to work, and if we run into actual problems, we can deal with it at that point. Thanks @consideRatio. |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/10002451764 |
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what can be done without breaking things as part of #4371 i think. The change in this PR is verified to work as intended for the 2i2c/binderhub-ui-demo hub.
Since this PR isn't honoring what I understood the task was meant to accomplish exactly, I'm requesting a review explicitly for this PR @yuvipanda. I realize now that the task title only mentions limits, but I ended up thinking it was about requests and limits.