Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter-health: add experimental hub image with oauthenticator 17.1 #4968

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Oct 16, 2024

oauthenticator 17.1 adds PKCE, which the Jupyter Health deployment is going to need quite shortly

This experiment is no longer required once JupyterHub chart is updated to >=4.0.0b4

I followed what I could of the steps for experimental images, but it looks like image registration on Quay.io and building with chartpress are not automated, so must be done by a person with 2i2c.org credentials.

btw, if it's possible to have a sample deployment migrated to the current beta of the chart, I'll volunteer Jupyter Health to be part of that, if that's easier than an experimental hub image. Jupyter Health will soon be using email addresses for login, which is a good exercise for the new kubespawner 7 slug scheme which handles email addresses differently.


minrk and others added 2 commits October 17, 2024 08:27
oauthenticator 17.1 adds PKCE, which the Jupyter Health deployment needs

This experiment is no longer required once JupyterHub chart is updated to 4.0.0b4
@consideRatio
Copy link
Member

Thank you @minrk! I'm working on getting this to land now

Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws jupyter-health No Yes Following helm chart values files were modified: common.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws jupyter-health prod Following helm chart values files were modified: common.values.yaml

Comment on lines -25 to -29
- name: support
images:
gcp-filestore-backups:
imageName: quay.io/2i2c/gcp-filestore-backups
valuesPath: gcpFilestoreBackups.image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but had to be cleaned up to get chartpress to build correctly so was done as part of this PR for simplicity - this image is now built in an external repo.

@consideRatio consideRatio changed the title add experimental hub image with oauthenticator 17.1 jupyter-health: add experimental hub image with oauthenticator 17.1 Oct 17, 2024
@consideRatio
Copy link
Member

Verified to startup correctly on staging, and the hub pod logs, and I've managed to login/logout/login without issues!

[I 2024-10-17 06:55:28.619 JupyterHub app:2915] Using Authenticator: oauthenticator.github.GitHubOAuthenticator-17.1.0

@consideRatio consideRatio merged commit 888478e into 2i2c-org:main Oct 17, 2024
7 of 8 checks passed
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/11379935187

@consideRatio
Copy link
Member

btw, if it's possible to have a sample deployment migrated to the current beta of the chart, I'll volunteer Jupyter Health to be part of that, if that's easier than an experimental hub image. Jupyter Health will soon be using email addresses for login, which is a good exercise for the new kubespawner 7 slug scheme which handles email addresses differently.

Thank you, I considered this but we lack a system to deploy two separate chart versions of z2jh currently in the CI/CD system so I figured we unblock this right away like this instead. Seeing oauthenticator 17.1 with PKCE verified to work without any issues against GitHub as an IDP was nice!

@consideRatio
Copy link
Member

This is now deployed!

@minrk minrk deleted the oauth-17.1 branch October 17, 2024 07:38
@minrk
Copy link
Contributor Author

minrk commented Oct 17, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Support] jupyter-health: help Min pilot use of oauthenticator 17.1
2 participants