Tweak CI so kops setup step only runs for AWS hubs #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgibson91
requested review from
yuvipanda and
damianavila
and removed request for
yuvipanda
sgibson91
commented
Sep 14, 2021
yuvipanda
approved these changes
Sep 14, 2021
|
This is lovely @sgibson91, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging #673 introduced a bug to do with curl when installing kops manually. This is breaking CI for all hubs, but should only affect hubs deployed on AWS not GCP. This PR adds in some provider information into the matrix job and updates the condition on the kops install step to only run when the provider is AWS.