Enabling GitHub Teams Authentication for the Pangeo Staging Hub #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures prod will continue to work as expected until we are ready to migrate the staging config onto prod
sgibson91
added
🏷️ active deployment
Enhancement
2 tasks
damianavila
reviewed
Oct 4, 2021
damianavila
reviewed
Oct 4, 2021
|
Just had this confirmed that this isn't working so marking it back as draft again. |
This prevents folk from logging in even if they're accepted by the org/team condition
|
We fixed this so ready to be reviewed/merged! |
yuvipanda
reviewed
Oct 4, 2021
|
I will merge this in 24 hours unless I receive an approving review before then |
This was referenced Oct 5, 2021
Closed
Merged
damianavila
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables authentication against the
@pangeo-data/us-central1-b-gcpGitHub Team on the Pangeo staging hub. Presently, I have explicitly defined the config for the prod hub so that we can control when we update prod to match staging, since prod has active users.2021-10-05 10:22 BST: I will merge this in 24 hours unless I receive an approving review before then