Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer support for enabling NFS protocol for azure storage #884

Merged
merged 5 commits into from
Dec 9, 2021
Merged

Offer support for enabling NFS protocol for azure storage #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b20bb81
Enable NFS 4 for the toronto hub
GeorgianaElena Dec 8, 2021
4c62400
Fix typo
GeorgianaElena Dec 8, 2021
9dbd7c1
Declare the terraform storage_protocol var
GeorgianaElena Dec 9, 2021
e44ca0d
Revert azurerm to 2.87.0 since this was the default before
GeorgianaElena Dec 9, 2021
a5d3626
Go with default storage_protocol for toronto
GeorgianaElena Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion terraform/azure/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "2.86.0"
version = "2.87.0"
}

azuread = {
Expand Down
1 change: 1 addition & 0 deletions terraform/azure/storage.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ resource "azurerm_storage_share" "homes" {
name = "homes"
storage_account_name = azurerm_storage_account.homes.name
quota = 100
enabled_protocol = var.storage_protocol
}

resource "kubernetes_namespace" "homes" {
Expand Down
12 changes: 12 additions & 0 deletions terraform/azure/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,15 @@ variable "create_service_principal" {
Principals for UToronto.
EOT
}

variable "storage_protocol" {
type = string
default = "SMB"
description = <<-EOT
The protocol used for the share. Possible values are SMB and NFS.

The SMB indicates the share can be accessed by SMBv3.0, SMBv2.1 and REST.
The NFS indicates the share can be accessed by NFSv4.1. Defaults to SMB.
Changing this forces a new resource to be created.
EOT
}