Add info about the grafana deployer action and api key #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
approved these changes
Jan 14, 2022
|
I just tried inviting the @2i2c-org/tech-team to review this, to see if we can test out our slack notification :-) |
Fix typos Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Thanks @choldgraf! I'll postpone merging it to check that we get the Slack reminders 🚀 |
There was a problem hiding this comment.
I made some suggestions related to the confusing terminology by GitHub.
My understanding is that:
- "GitHub Actions" is like saying "TravisCI" or "CircleCI", it is the name of the system to run CI/CD stuff.
- Within GitHub Actions, GitHub's CI system, you can run "workflows", and each workflow has a list of "jobs", and each job has a list of "steps".
- A "GitHub action" is a pre-defined "step" that can be re-used across workflows defined in projects across GitHub
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
Thank you @consideRatio for clarifying these 🌼 |
|
Thanks everyone 🌼 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When researching about #328 realized that we haven't documented the grafana deployer action and where the api key is stored right now.
I believe it closes 2i2c-org/team-compass#176
Probably this will change when we'll have one grafana for all the clusters.