Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textblob & bump to jupyterhub 3.0 #31

Merged
merged 6 commits into from
Sep 15, 2022
Merged

Add textblob & bump to jupyterhub 3.0 #31

merged 6 commits into from
Sep 15, 2022

Conversation

yuvipanda
Copy link
Member

@yuvipanda yuvipanda commented Jun 24, 2022

  • Move bioconductor install to separate file, so we don't end up
    busting the general R cache each time we need to fiddle with
    bioconductor
  • Explicitly install an older version of locfit so bioconductor can
    install edgeR
  • Install newer version of jupyterhub, so interface selection works
    again
  • Install textblob

Fixes #33

@github-actions
Copy link

Binder 👈 Test this PR on Binder

@yuvipanda
Copy link
Member Author

This doesn't actually block upgrading to z2jh, as jupyterhub is already >1.5.0 on this

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the building images workflow is killed again because of OOM 😕

The exit code of last process:

  The command '/bin/sh -c conda env update -p ${CONDA_DIR} -f /tmp/environment.yml && conda clean -afy' returned a non-zero code: 137

@yuvipanda
Copy link
Member Author

Yeah, I'll switch this over to mamba.

Dockerfile Outdated
@@ -112,8 +112,8 @@ RUN apt-get update -qq --yes && \

WORKDIR /home/jovyan

COPY install-miniforge.bash /tmp/install-miniforge.bash
RUN /tmp/install-miniforge.bash
COPY install-mambaforge.bash /tmp/install-mambaforge.bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely 😉.

@yuvipanda
Copy link
Member Author

Check succeeded, but bio R package installs are still failing :D I'll take another look soon

I got these by looking at the current running versions
on the hub. This makes sure users don't accidentally
see version changes
@yuvipanda yuvipanda changed the title Bump jupyterhub version to 2.3.x Add textblob & bump to jupyterhub 3.0 Sep 15, 2022
@yuvipanda
Copy link
Member Author

All fixed!

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaaaaaaaaaaaay 🚀 LGTM 🚀

@yuvipanda yuvipanda merged commit f61cffc into main Sep 15, 2022
@damianavila damianavila deleted the yuvipanda-patch-1 branch September 16, 2022 00:39
- statsmodels==0.13.*
- nltk==3.6.*
- spacy==3.2.*
- geopandas==0.10.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love all these pins!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Request to install python package textblob
3 participants