Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch base to rocker/binder image #11

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Switch base to rocker/binder image #11

merged 2 commits into from
Nov 2, 2023

Conversation

yuvipanda
Copy link
Member

Ref 2i2c-org/infrastructure#3178

- Matches what we do in other images
- Simplifies this image *a lot*
- Knitting still takes time the *first time* even if we just switch to
  new base image. But rocker-org/rocker-versioned2#714
  installs some of the texlive packages that are being installed the
  first time, and should speed things up.

Ref 2i2c-org/infrastructure#3178
Copy link

github-actions bot commented Nov 1, 2023

Binder 👈 Test this PR on Binder

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuvipanda!

Matches what we do in other images

Would love to have some quick bullet points written about this in https://infrastructure.2i2c.org/howto/update-env/#update-the-default-user-environment as I believe that one is not accurate anymore, right?

But totally not related with this PR which can be merged as it is 🚀

@yuvipanda
Copy link
Member Author

@GeorgianaElena I think this is documented in https://infrastructure.2i2c.org/howto/features/rocker/ as us prefering using rocker/binder image. Do you think that's enough?

@yuvipanda yuvipanda merged commit bb58a48 into main Nov 2, 2023
1 check passed
@GeorgianaElena
Copy link
Member

@yuvipanda, yes, totally. That does a great job explaining the why and how <3

I think maybe what we're missing is a central place like https://infrastructure.2i2c.org/howto/update-env/#manage-a-hub-s-user-environment that explains the when?

Maybe an aggregator docs page of 2i2c "recommended" images and when they can be used (like proposed in 2i2c-org/infrastructure#3103), followed by the guide on how to use the repo2docker action to quickly build on top of them if/when needed.

I believe I'm imagining your great JupyterCon talk in a docs page with links towards pages like https://infrastructure.2i2c.org/howto/features/rocker/ if that makes sense :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants