NShiftKey

• Use try-with-resources or close this "BufferedReader" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : weld-core/examples/jsf/pastecode/src/ftest/java/org/jboss/weld/examples/pastecode/ftest/PasteCodeTest.java [view change history] [ignore this]
      

      weld-core/examples/jsf/pastecode/src/ftest/java/org/jboss/weld/examples/pastecode/ftest/PasteCodeTest.java

      Lines 254 to 256 in 5d1fd80

      	URL downloadUrl = new URL(driver.findElement(by).getAttribute("href"));
      	BufferedReader r = new BufferedReader(new InputStreamReader(downloadUrl.openStream()));
      	String str;

      
        
    • Target Code : weld-core/impl/src/main/java/org/jboss/weld/util/ServiceLoader.java [view change history] [ignore this]
      

      weld-core/impl/src/main/java/org/jboss/weld/util/ServiceLoader.java

      Lines 177 to 179 in 5d1fd80

      	is = serviceFile.openStream();
      	BufferedReader reader = new BufferedReader(new InputStreamReader(is, "UTF-8"));
      	String serviceClassName = null;

      
        
    • Target Code : weld-core/tests-arquillian/src/test/java/org/jboss/weld/tests/injectionPoint/weld1823/Weld1823Test.java [view change history] [ignore this]
      

      weld-core/tests-arquillian/src/test/java/org/jboss/weld/tests/injectionPoint/weld1823/Weld1823Test.java

      Lines 56 to 58 in 5d1fd80

      	BufferedReader reader = new BufferedReader(new InputStreamReader(url.openStream()));
      	assertEquals(reader.readLine(), "Test Sucessful!");

      
        

• Use try-with-resources or close this "FileWriter" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : weld-core/tests-arquillian/src/main/java/org/jboss/weld/tests/TestClassToHashMapper.java [view change history] [ignore this]
      

      weld-core/tests-arquillian/src/main/java/org/jboss/weld/tests/TestClassToHashMapper.java

      Lines 34 to 36 in 5d1fd80

      	}
      	FileWriter writer = new FileWriter(outputFile);
      	List<File> files = (List<File>) FileUtils.listFiles(userDir, new TestFileFilter(), new DirFileFilter());

      
        

• Remove this throw statement from this finally block.

  • Description : https://rules.sonarsource.com/java/RSPEC-1143/
    • Target Code : weld-core/impl/src/main/java/org/jboss/weld/util/ServiceLoader.java [view change history] [ignore this]
      

      weld-core/impl/src/main/java/org/jboss/weld/util/ServiceLoader.java

      Lines 194 to 196 in 5d1fd80

      	} catch (IOException e) {
      	throw new RuntimeException("Could not close services file " + serviceFile, e);
      	}

      
        
    • Target Code : weld-core/probe/core/src/main/java/org/jboss/weld/probe/IOUtils.java [view change history] [ignore this]
      

      weld-core/probe/core/src/main/java/org/jboss/weld/probe/IOUtils.java

      Lines 92 to 94 in 5d1fd80

      	} catch (IOException e) {
      	throw new IllegalStateException(e);
      	}

      
        
    • Target Code : weld-core/probe/core/src/main/java/org/jboss/weld/probe/IOUtils.java [view change history] [ignore this]
      

      weld-core/probe/core/src/main/java/org/jboss/weld/probe/IOUtils.java

      Lines 67 to 69 in 5d1fd80

      	} catch (IOException e) {
      	throw new IllegalStateException(e);
      	}

      
        

• Remove this return statement from this finally block.

  • Description : https://rules.sonarsource.com/java/RSPEC-1143/
    • Target Code : weld-core/impl/src/main/java/org/jboss/weld/util/reflection/Formats.java [view change history] [ignore this]
      

      weld-core/impl/src/main/java/org/jboss/weld/util/reflection/Formats.java

      Lines 199 to 201 in 5d1fd80

      	} catch (Exception e) {
      	return 0;
      	}