Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jabba installation step #5

Merged
merged 2 commits into from
May 27, 2020
Merged

Add jabba installation step #5

merged 2 commits into from
May 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 26, 2020

Fixes #4 .

README.md Outdated

This is a [fish](https://fishshell.com) plugin for [jabba](https://github.com/shyiko/jabba). Together with packaging the [original shell integration code](https://github.com/shyiko/jabba/blob/1ca1e8a12f9e4c45530e2c652d79483678eef9c0/install.sh#L163-L172) required for jabba to work correctly, this plugin also includes autocompletion support for the following commands:
This is a [fish](https://fishshell.com) plugin for [jabba](https://github.com/shyiko/jabba). T
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bit of a strange split. :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I totally missed that. Correcting.

Copy link
Owner

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

@2m 2m merged commit aabd098 into master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README clarity
1 participant