Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minified file not actually minified: dist/inpage/inpage.min.js #3200

Closed
jeremy-farrance opened this issue Nov 2, 2023 · 1 comment
Closed
Assignees

Comments

@jeremy-farrance
Copy link

I'm submitting a

[x] (somewhat trivial) bug report

...about

[x] edit experience / UI
[x] admin experience UI

Current Behavior / Expected Behavior

This file inpage.min.js started bogging down (disk-read) performance on our server on an Intranet project**. We were suprised the file was so large and noticed that even though the file has ".min." in it, it was not minified. So, shouldn't it be? Maybe its worth checking something in your build for release process? It over 3/4s of a MB as is (in v16.07.00).

** because we unnecessarily had Kit.Page.Activate("2sxc.something") happening on a page with a custom form (Activate was needed for editors, but not all users). Fixed it so it only loaded when needed AND got it to cache (it wasn't).

image

Your environment

  • 2sxc version(s): 16.06.00
  • Browser: all/any
  • DNN: all | 9.13.00 | 9.11.02
  • Hosting platform: IIS
  • Language: any/all
@iJungleboy
Copy link
Contributor

I can confirm this issue.
@tvatavuk could you check / fix?

@iJungleboy iJungleboy assigned iJungleboy and tvatavuk and unassigned iJungleboy Nov 6, 2023
iJungleboy added a commit to 2sic/2sxc-ui that referenced this issue Nov 7, 2023
@iJungleboy iJungleboy assigned iJungleboy and unassigned tvatavuk Nov 22, 2023
@iJungleboy iJungleboy moved this to Vv16.09 in 2sxc 16 Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Vv16.09
Development

No branches or pull requests

3 participants