Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of ask command #3

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Implementation of ask command #3

merged 3 commits into from
Jul 11, 2024

Conversation

kechigon
Copy link
Collaborator

@kechigon kechigon commented Jul 4, 2024

概要 PRでの対応内容の概要

askコマンドの実装

原因と対処法(バグ修正の場合) 何が原因と判断し、どう対処したのか

やったこと 対応内容を簡潔にリストアップ

  • commandがaskだった場合の、プロンプトにask固有の文章を含める処理
    • "The following is the GitHub Issue and comments on it. Based on the content provide a detailed response to the following question:\n"
  • askしたい文章を渡すintent引数の追加
  • askコマンドかつintent引数がない場合のエラーハンドリング
  • GitHubからコンテキストをとってこれなかった場合のエラーハンドリング

変更結果 操作動画やスクショ、レスポンス内容など

#3 (comment)

やらないこと このPRでスコープ外とする内容

command引数に想定していない文字列が来たときのエラーハンドリング

注意事項 マージした後はこのコマンドを実行してね、などメンバーに知らせるべき内容

どうやるのか 変更後の使い方や再現(確認)手順

#3 (comment) の実行コマンドを参考にしてください。(ローカル実行)

Actionsでintentを渡しaskコマンドを渡す方法は具体的には決めてないが、実現可能だと思う。

課題 悩んでいるところ、とくにレビューしてほしいところ(これは直接ソースにコメントしてもいいと思います。)

備考 その他追記事項、関連資料や参考資料などをまとめる

@kechigon kechigon requested review from nwiizo and pacificbelt30 July 4, 2024 09:25
@kechigon
Copy link
Collaborator Author

kechigon commented Jul 4, 2024

goreleaserよくわからないです。

@pacificbelt30
Copy link
Collaborator

goreleaser がタグを push したときに以外にプルリクにも反応するようになってました。。
後で消しておきます

@pacificbelt30 pacificbelt30 marked this pull request as ready for review July 8, 2024 06:05
cmd/main.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
@kechigon
Copy link
Collaborator Author

kechigon commented Jul 9, 2024

上記リポ名のtypoでした。すみません

動きましたー

Issue

Overview
There is an issue where users are not receiving notifications for comments sent using the Feedback feature.

issue details
Version: v1.2.3
Environment: Windows 10, Google Chrome 94.0.4606.81
Phenomenon
post a comment using the "Send Feedback" form in the application. 2.
Another user replies to your comment. 3.
The user who posted the comment should receive a reply notification, but no notification is received.
Steps to Reproduce
Start the application and login as user A. 2) Open the feedback form.
Open the feedback form and post a comment. 3.
Log in as user B and post a reply to user A's comment. 4.
As User A, check for notifications, but no notifications appear.
Expected Results
User A should receive a notification that a reply to their feedback has been received.

Actual Result
User A does not receive any notification at all.

Additional Information
We confirmed that all notification settings are enabled.
We have tried clearing the browser cache and deleting cookies, but this did not resolve the issue.
Similar problems are occurring among other users.
Suggestions
Until this issue is fixed, please re-evaluate your notification system and take immediate action, as important feedback may be missed. Also, please consider utilizing the email notification feature as a temporary measure.

Thank you for your confirmation.

実行コマンド(ローカル)

go run ./cmd/main.go -owner kechigon -issue 4 -repo alert-ment-lab -github-token *** -api-key *** -command ask -intent "Could you provide suggested steps or checkpoints for troubleshooting the notification feature?"

レスポンス

Troubleshooting the notification feature for this issue can be done by following these suggested steps or checkpoints:

Verify Notification Settings:

Ensure that the notification settings within the application are correctly enabled for User A to receive notifications for comments on feedback.
Check Browser Compatibility:

Confirm that the browser being used (Google Chrome 94.0.4606.81 in this case) is compatible with the application and is not causing any conflicts with the notification system.
Test Notification System:

Perform a test by having User A post a comment and User B reply to it to see if notifications are being triggered in a timely manner. This can help identify if the issue is specific to certain scenarios or is a consistent problem.
Inspect Network Requests:

Use developer tools in the browser to monitor network requests when a comment is posted and a reply is made. Check if the notification requests are being sent and received properly.
Review Server Logs:

Look into the server logs to see if there are any errors or issues being logged related to notification delivery. This can provide insights into potential backend problems causing the notifications not to be sent.
Explore Email Notifications:

As a temporary measure, consider utilizing the email notification feature to ensure that users are informed about feedback replies until the notification issue is resolved.
Collaborate with Users:

Reach out to other users experiencing similar notification problems to gather more information and feedback on the issue. This can help in identifying any common patterns or triggers causing the problem.
Prioritize Fixing:

Acknowledge the importance of timely feedback notifications and prioritize addressing this issue promptly to prevent any important feedback from being missed.
By following these steps and checkpoints, the troubleshooting process for the notification feature can be methodical and comprehensive, leading to effective resolution of the issue.

@pacificbelt30
Copy link
Collaborator

実際の Chrome の issue? で試していただいてありがとうございます!動作自体は問題なさそうです!
実行コマンドにシークレットが出ちゃってるので編集しておいてもらえると助かります!

@pacificbelt30
Copy link
Collaborator

マージします!

@pacificbelt30 pacificbelt30 merged commit d5c5fb8 into develop Jul 11, 2024
1 check failed
@pacificbelt30
Copy link
Collaborator

プルリクの編集履歴が見れちゃうみたいなので、実行コマンドを載せてあるコメントの履歴を消去(不可視)したほうが良いかもしれないです。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants