PR Feedback. VB's MergeUseSiteInfo now behaves the same as C#, taki…

…ng the first argument byref instead of byvalue.

src/Compilers/CSharp/Portable/Symbols/EventSymbol.cs

@@ -314,7 +314,7 @@ public sealed override bool HasUnsupportedMetadata
             get
             {
                 DiagnosticInfo? info = GetUseSiteInfo().DiagnosticInfo;
-                return (object?)info != null && info.Code == (int)ErrorCode.ERR_BindToBogus;
+                return (object?)info != null && info.Code is (int)ErrorCode.ERR_BindToBogus or (int)ErrorCode.ERR_UnsupportedCompilerFeature;
             }
         }
 

src/Compilers/CSharp/Portable/Symbols/FieldSymbol.cs

@@ -373,7 +373,7 @@ internal bool CalculateUseSiteDiagnostic(ref UseSiteInfo<AssemblySymbol> result)
         }
 
         /// <summary>
-        /// Return error code that has highest priority while calculating use site error for this symbol. 
+        /// Returns true if the error code is highest priority while calculating use site error for this symbol. 
         /// </summary>
         protected sealed override bool IsHighestPriorityUseSiteErrorCode(int code) => code is (int)ErrorCode.ERR_UnsupportedCompilerFeature or (int)ErrorCode.ERR_BindToBogus;
 
@@ -382,7 +382,7 @@ public sealed override bool HasUnsupportedMetadata
             get
             {
                 DiagnosticInfo info = GetUseSiteInfo().DiagnosticInfo;
-                return (object)info != null && info.Code == (int)ErrorCode.ERR_BindToBogus;
+                return (object)info != null && info.Code is (int)ErrorCode.ERR_BindToBogus or (int)ErrorCode.ERR_UnsupportedCompilerFeature;
             }
         }
 

src/Compilers/CSharp/Portable/Symbols/MethodSymbol.cs

@@ -1056,7 +1056,7 @@ static bool isGenericMethod([DisallowNull] MethodSymbol? method)
 #nullable disable
 
         /// <summary>
-        /// Return error code that has highest priority while calculating use site error for this symbol.
+        /// Returns true if the error code is highest priority while calculating use site error for this symbol.
         /// </summary>
         protected sealed override bool IsHighestPriorityUseSiteErrorCode(int code) => code is (int)ErrorCode.ERR_UnsupportedCompilerFeature or (int)ErrorCode.ERR_BindToBogus;
 
@@ -1065,7 +1065,7 @@ public sealed override bool HasUnsupportedMetadata
             get
             {
                 DiagnosticInfo info = GetUseSiteInfo().DiagnosticInfo;
-                return (object)info != null && info.Code == (int)ErrorCode.ERR_BindToBogus;
+                return (object)info != null && info.Code is (int)ErrorCode.ERR_BindToBogus or (int)ErrorCode.ERR_UnsupportedCompilerFeature;
             }
         }
 

src/Compilers/CSharp/Portable/Symbols/ParameterSymbol.cs

@@ -428,7 +428,7 @@ public sealed override bool HasUnsupportedMetadata
             {
                 UseSiteInfo<AssemblySymbol> info = default;
                 DeriveUseSiteInfoFromParameter(ref info, this);
-                return info.DiagnosticInfo?.Code == (int)ErrorCode.ERR_BogusType;
+                return info.DiagnosticInfo?.Code is (int)ErrorCode.ERR_BogusType or (int)ErrorCode.ERR_UnsupportedCompilerFeature;
             }
         }
 

src/Compilers/CSharp/Portable/Symbols/PropertySymbol.cs

@@ -400,7 +400,7 @@ internal bool CalculateUseSiteDiagnostic(ref UseSiteInfo<AssemblySymbol> result)
         }
 
         /// <summary>
-        /// Return error code that has highest priority while calculating use site error for this symbol. 
+        /// Returns true if the error code is highest priority while calculating use site error for this symbol. 
         /// </summary>
         protected sealed override bool IsHighestPriorityUseSiteErrorCode(int code) => code is (int)ErrorCode.ERR_UnsupportedCompilerFeature or (int)ErrorCode.ERR_BindToBogus;
 

src/Compilers/CSharp/Portable/Symbols/Symbol.cs

@@ -939,7 +939,7 @@ protected AssemblySymbol PrimaryDependency
         }
 
         /// <summary>
-        /// Return error code that has highest priority while calculating use site error for this symbol. 
+        /// Returns true if the error code is the highest priority while calculating use site error for this symbol. 
         /// Supposed to be ErrorCode, but it causes inconsistent accessibility error.
         /// </summary>
         protected virtual bool IsHighestPriorityUseSiteErrorCode(int code) => true;
@@ -967,7 +967,7 @@ public virtual bool HasUnsupportedMetadata
         {
             get
             {
-                return false;
+                return GetUseSiteInfo().DiagnosticInfo?.Code == (int)ErrorCode.ERR_UnsupportedCompilerFeature;
             }
         }
 

src/Compilers/CSharp/Portable/Symbols/TypeSymbol.cs

@@ -517,17 +517,18 @@ internal Microsoft.Cci.PrimitiveTypeCode PrimitiveTypeCode
         #region Use-Site Diagnostics
 
         /// <summary>
-        /// Return error code that has highest priority while calculating use site error for this symbol. 
+        /// Returns true if the error code is highest priority while calculating use site error for this symbol. 
         /// </summary>
-        protected sealed override bool IsHighestPriorityUseSiteErrorCode(int code) => code is (int)ErrorCode.ERR_UnsupportedCompilerFeature or (int)ErrorCode.ERR_BindToBogus;
+        protected sealed override bool IsHighestPriorityUseSiteErrorCode(int code)
+            => code is (int)ErrorCode.ERR_UnsupportedCompilerFeature or (int)ErrorCode.ERR_BindToBogus or (int)ErrorCode.ERR_BogusType;
 
 
         public sealed override bool HasUnsupportedMetadata
         {
             get
             {
                 DiagnosticInfo info = GetUseSiteInfo().DiagnosticInfo;
-                return (object)info != null && info.Code == (int)ErrorCode.ERR_BogusType;
+                return (object)info != null && info.Code is (int)ErrorCode.ERR_BogusType or (int)ErrorCode.ERR_UnsupportedCompilerFeature;
             }
         }