Adding schain info

[curlyblueeagle]

Schain Info is added as follows:

• If schain object exists in bidRequests (the object that prebid passes to adapter during bid request phased to build and send requests) then try to infer schain
• If schain info is valid then add it to the source field.
• If schain info passed is not valid then set source to null

[terryc33x]

maybe change !schain.nodes.length > 0 to !(schain.nodes.length > 0) or schain.nodes.length < 1 for easy readability

[curlyblueeagle]

why is schain.nodes.length < 1 more readable than !schain.nodes.length > 0?
I will add the paren to make it clear.

[terryc33x]

because !schain.nodes.length > 0 will do this (!schain.nodes.length) > 0

[curlyblueeagle]

Yikes yes you are correct. Thank you.

[curlyblueeagle]

That's a bug then not just readability issue? Hmm how did my valid schain unit test pass then? Because !1 > 0 evaluates to false?

[terryc33x]

because it will covert the boolean to number and then compare with 0, eg. number(boolean(length)) so if not empty array, it will return 0, and empty array will return 1, which still satisfied the x>0 logic

[curlyblueeagle]

Haha I replied first. But thanks for spotting this. Fixed by adding paren.

[terryc33x]

lol, okok, you win...btw, are you keep refreshing the page??

[terryc33x]

my page does not auto update the comment

[curlyblueeagle]

Ah no I did not refresh page. But I also notice that only a page refresh updates comments. Not like gitlab

[terryc33x]

does empty string and 0 fail this check?

[curlyblueeagle]

It should yes. The values of asi, sid should be a valid string and hp should be 1+.

[curlyblueeagle]

Here's what the validation is based on https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/supplychainobject.md#openrtb-object-supplychain

Too strict?

[terryc33x]

i see, that make sense

[fchristle]

I am not sure how strictly we want to validate here. But this would pass if hp had any valid string or boolean true value too?

[curlyblueeagle]

Right that is true (no pun intended). Hmm I guess this only checks for truthy values. Should we enforce proper validation here?

[fchristle]

This is interesting. I wonder if we need to add this to our validation too for schain nodes.

[fchristle]

I am not sure how strictly we want to validate here. But this would pass if hp had any valid string or boolean true value too?