Conversation
didOpenSetting 플래그 변수 추가
전체 관리 : ParentQuestViewController 나의 여정 : QuestCheckViewController 공통 여정 : CommonQuestViewController
…eat/#354-questTopTabBar
2 tasks
juri123123
approved these changes
Feb 16, 2026
Comment on lines
+17
to
+21
| init(items: T.AllCases) { | ||
| self.tabBar = TopTabBar(items: Array(items)) | ||
| self.controllers = items.map { $0.viewController } | ||
| super.init(nibName: nil, bundle: nil) | ||
| } |
Comment on lines
+73
to
+94
| private func show(_ target: UIViewController) { | ||
| guard currentViewController != target else { return } | ||
|
|
||
| if let currentViewController { | ||
| currentViewController.do { | ||
| $0.willMove(toParent: nil) | ||
| $0.view.removeFromSuperview() | ||
| $0.removeFromParent() | ||
| } | ||
| } | ||
|
|
||
| addChild(target) | ||
| containerView.addSubview(target.view) | ||
| target.view.snp.makeConstraints { | ||
| $0.verticalEdges.equalToSuperview() | ||
| $0.horizontalEdges.equalToSuperview() | ||
| } | ||
|
|
||
| target.didMove(toParent: self) | ||
| currentViewController = target | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
처음 보는 친구들이라 찾아보니 커스텀 탭바를 사용할 때 사용해줘야하는 친구들이군요 ! 배워갑니당 ~
Collaborator
There was a problem hiding this comment.
여기 변경사항은 as-is랑 to-be가 어떻게 바뀐건가요?
y-eonee
approved these changes
Feb 17, 2026
ByeBoo-iOS/ByeBoo-iOS/Presentation/Common/TopTabBar/TopTabBar.swift
Outdated
Show resolved
Hide resolved
Comment on lines
+17
to
+21
| init(items: T.AllCases) { | ||
| self.tabBar = TopTabBar(items: Array(items)) | ||
| self.controllers = items.map { $0.viewController } | ||
| super.init(nibName: nil, bundle: nil) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
💻 주요 코드 설명
TabItemTabBarItemViewTopTabBarParentQuestViewController