Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修正改善 #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

修正改善 #15

wants to merge 3 commits into from

Conversation

Zhengqi
Copy link

@Zhengqi Zhengqi commented Nov 20, 2015

  1. 修复了视频进度条在视频播放完未停在末尾的问题
  2. 增加了delegate来追踪视频是否播放完毕, 并响应Parent Controller
  3. 支持ATS,允许播放http开头的视频url

aidenluo177
aidenluo177 reviewed Nov 30, 2015
View reviewed changes
Pod/Classes/KRVideoPlayerController.h
@interface KRVideoPlayerController : MPMoviePlayerController

@property (assign, nonatomic) id _delegate;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为了全局命名规范，修改为@Property (weak, nonatomic) id delegate;

关键点，1.weak， 2.id, 3.delegate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zhengqi @aidenluo177