Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6099 - systemd = False has no effect #6101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vashirov
Copy link
Member

Bug Description:
systemd = False doesn't override with_systemd = 1 from defaults.inf when used with dscreate. It is only effective when setup is running in a containerized environment (via dscontainer). But for some special use cases it's important that DS installation runs without systemd.

Fix Description:
Remove the condition for overriding systemd flag.
systemd option is not exposed in the default template, it's listed there only when --advanced flag is used, so it should not affect regular installations.

Fixes: #6099

Bug Description:
`systemd = False` doesn't override `with_systemd = 1` from
`defaults.inf` when used with `dscreate`. It is only effective when
setup is running in a containerized environment (via `dscontainer`).
But for some special use cases it's important that DS installation runs
without systemd.

Fix Description:
Remove the condition for overriding systemd flag.
`systemd` option is not exposed in the default template, it's listed
there only when `--advanced` flag is used, so it should not affect
regular installations.

Fixes: 389ds#6099
@vashirov
Copy link
Member Author

dscreate tests in the basic test suite fail because of the assert in the try..except block, it prevents finalizer to run to clean up and remove the instance before the next test. Working on the tests fix...

@vashirov
Copy link
Member Author

This uncovered another issue: server can't be stopped, if it was created with systemd = False. ns-slapd keeps running, because lib389 has no idea that the override existed when the instance was created, and tries to stop it using systemd (because with_systemd = 1 is in the defaults.inf). And we don't expose this in .dsrc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dscreate: "start = False" and "systemd = False" have no effect
1 participant