fix buffer owerflow in the function parseVariant
#6335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`variant[0]` can have a maximum value of 72. `field->var = variant0 - VAR_MIN;`, so a maximum value `field->var = 7` This is a buffer overflow in the line `obj->var[field->var] = (char *)malloc(MAX_FILTER)` if it accesses the array at index 7, an overflow will occur.
progier389
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Sorry but I do not think that this fix is correct:
As the error message said, variable are expected to be within between VAR_MIN and VAR_MAX.
If there is a buffer overflow that is the array size that must be changed rather than limiting the variable range ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variant[0]can have a maximum value of 72.field->var = variant0 - VAR_MIN;, so a maximum valuefield->var = 7This is a buffer overflow in the line
obj->var[field->var] = (char *)malloc(MAX_FILTER)if it accesses the array at index 7, an overflow will occur.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Reporter: Dmitriy Fedin (d.fedin@fobos-nt.ru).