Add Configurable Number of Iterations for PBKDF2 Design doc #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droideck
force-pushed
the
pbkdf2-num-iter-design
branch
from
af0351a to
581fef2
Compare
tomato42
reviewed
Jan 2, 2025
| - **Minimum Iterations**: 10,000 | ||
| - **Maximum Iterations**: 10,000,000 | ||
|
|
||
| These defaults and limits ensure a baseline security level and guard against extreme performance degradation. |
There was a problem hiding this comment.
while that's a good goal, what was the exact criterion?
For interactive systems the recommendation is that it should require about 100ms of calculation time on a modern CPU. Good 7 years ago 1M iterations could be calculated at around a second (https://bugzilla.mozilla.org/show_bug.cgi?id=1278071 )
There was a problem hiding this comment.
I'll test it a bit more, and I think I'll increase the default (even though initially the PR was just about the setting, I think it'll be better to handle the default increase here, too as we haven't done it in some time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.