Address #142, makerom no longer strictly requires ELFs to have a data segment #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issues with 11.17 |
|
Thank you for checking so quickly, I hadn't even uploaded any binaries. I'll merge this to the main branch soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This is in response to #142 where @kynex7510 reported that makerom was unable to use ELFs that only had a text segment. This is relevant to https://github.com/hax0kartik/3ds_pdn which is an open source implementation of the PDN module. That project has a work around to create a dummy data segment, just so makerom will process it. Ultimately such a workaround shouldn't be needed.
Changes
Very minimal, just changes the logic in
code.cto safely tolerate ELF files with no data segment.