New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mvp street segment #910

Closed

kfarr opened this issue Nov 2, 2024 · 1 comment · Fixed by #912

Collaborator

kfarr commented Nov 2, 2024 •

edited

Loading

the segment has length, width, type to start?
it controls the box of geometry beneath it that is created depending on type?
type are similar values to streetmix like sidewalk, bus-lane, bike-lane, drive-lane, etc.
it replaces https://github.com/3DStreet/3dstreet/blob/main/src/aframe-streetmix-parsers.js#L901 and this logic is instead moved to this new component and/or yet another sub-component
this can also be a "drop zone"

kfarr added this to 3DStreet Dev Tracking

kfarr converted this from a draft issue

kfarr moved this from To Do - High Prio to In progress in 3DStreet Dev Tracking

Collaborator Author

kfarr commented Nov 4, 2024

Step 1 convert streetmix parser to use street-segment instead of ground mixins defined in asset.js

We want to turn this function into a component:
https://github.com/3DStreet/3dstreet/blob/main/src/aframe-streetmix-parsers.js#L901

For example:

<a-entity street-way="source: [json]">
    <a-entity street-segment="preset: drive-lane; width: 3; length: 150"></a-entity>
    <a-entity street-segment="preset: bus-lane; width: 6; length: 150"></a-entity>
</a-entity>

kfarr linked a pull request

that will close this issue

street-segment wip #912

Merged

kfarr closed this as completed in #912

github-project-automation bot moved this from In progress to Done in 3DStreet Dev Tracking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment