Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

street-segment wip #912

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

street-segment wip #912

wants to merge 36 commits into from

Conversation

kfarr
Copy link
Collaborator

@kfarr kfarr commented Nov 4, 2024

No description provided.

@kfarr kfarr linked an issue Nov 4, 2024 that may be closed by this pull request
@kfarr
Copy link
Collaborator Author

kfarr commented Nov 7, 2024

trimmed2.mov

it looks like this is in our "state" database but when I load it it doesn't work:
"street-segment": "preset: bike-lane; width: 1.5; length: 60; color: #859dff; surface: sidewalk"

if i do imperative, this works correctly:

     segmentParentEl.setAttribute('street-segment', 'preset', segmentPreset);
      segmentParentEl.setAttribute(
        'street-segment',
        'width',
        segmentWidthInMeters
      );
      segmentParentEl.setAttribute('street-segment', 'length', length);
      segmentParentEl.setAttribute('street-segment', 'elevation', elevation);
      segmentParentEl.setAttribute('street-segment', 'color', segmentColor);```

@kfarr
Copy link
Collaborator Author

kfarr commented Nov 7, 2024

@kfarr
Copy link
Collaborator Author

kfarr commented Nov 12, 2024

what is remaining before releasing this?

  • - separator segments need to have correct elevation
  • - spawned objects to have correct elevation (parent of cloned)
  • - support for rail asphalt
  • - testing saving / loading
  • - what happens when the scale or other elements are modified?
  • - confirm data types work with rahul's overview
  • - optional - custom sidepanel for street-segment? just bump it up

open questions

  • should street-segment be renamed to street-surface to more accurately reflect its purpose?
  • should there be a 'street-managed' component that connects to the data store and updates all child components?
  • how to handle user desire to move placed objects and save those changes? how to make it easy to convert to custom placement?

remaining to convert to new street segment components:

  • lamps - clone standard
  • pride flag variants - custom object may need conversion?
  • fence - buildings / lots
  • seawall - buildings / lots
  • transit shelter - fixed
  • bikeshare - fixed
  • bus - random
  • lrv, trolley - random
  • createBrtStationElement
  • outdoor dining
  • flex zone
  • micromobility
  • parklet
  • foodtruck - random
  • cars in drive lane
  • wayfinding - custom object may need conversion?
  • stencils single
  • stencils multiple
  • sidewalk pedestrians
  • parked cars
  • striping
  • magic carpet

@kfarr kfarr marked this pull request as ready for review November 12, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mvp street segment street segments with negative elevation results in NaN x position raising console errors
1 participant