-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruler tools #1080
Ruler tools #1080
Conversation
can be selected but doesn't do anything yet
not really working
For label, you can use CSS2DObject/CSS2DRenderer |
@vincentfretin thanks for all the updates. The last commit that returns early on mouseup if camera has moved makes sense in theory, but in practice it seems to result in some valid clicks to the ruler not being recognized, both first or second ruler point placement clicks do not have an effect (even without apparent camera movement) approx 1/6th of the time. Perhaps cameramoved is firing too aggressively. After reverting it works OK where the user click is double counted as a ruler point placement and move event, and they can just undo the placement of the measure-line if they make one by mistake. I wonder if there's a way to have a different type of threshold like the total distance the camera has moved at clickup, and the ruler click registers if the distance < 0.1, for example |
swap add layer and ruler icon ordering
nice labels |
Units switch for ruler tools
Must fix issues:
Other issues:
nice to have / to fix later:
(moved to #1081)
wait until people ask for it: