-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-Build event no longer work as expected (if compared to UnmanagedExports) #35
Comments
Because of different environment, tools, etc. For example, often, I (especially) use vssbe scripts instead of this std. VS Build Events :) But mainly I have no see any problems as you described for this issue. I mean this:
I don't see any wildcards like ., *.exp, etc. from your demo projects, and I see expected result for simple command Please check your command, because it can be like this (as I understand for your case): xcopy /Y "$(SolutionDir)$(ProjectName)\$(OutputPath)*.*" "$(SolutionDir)" and similar... since we are talking also about vssbe, same example: #[IO copy.file("$(ProjectName)\$(OutputPath)*.*", "$(SolutionDir)", true)] or like: #[$(app = "$(SolutionDir)$(ProjectName)\$(OutputPath)")]
#[IO copy.file({
"$(app)*.dll",
"$(app)*.exp",
"$(app)*.lib"
},
"$(SolutionDir)",
true,
{ "$(app)*.pdb" })] and other So please review your problem again. And thanks for demo projects, because it always saves my time anyway :) |
I think you have misunderstood the issue here. You though of .exp/.obj generated files? Where did I mention those? Nowhere in above description have I mention anything about exp, obj, or wildcards, vssbe scripts, xcopy, etc. So obviously you misunderstood it, and the point is not to copy ALL files, just the compiled DLL (but that's less important). The main issue is that post-build event is not run at correct time with DllExport package, thus it copied DLL without any exports. Get it? Edit: |
You about records from IMAGE_DATA_DIRECTORY :) for std. VS build-events I will look later, thanks. temporarily you can try with vssbe, or try something manually via targets. |
…#35 use this if still is needed: ``` <Target Name="PostBuildEventBeforeDllExport" BeforeTargets="DllExportMod"> ... </Target> ```
please check it with latest changes - https://ci.appveyor.com/project/3Fs/dllexport/build/build-45/artifacts But now we can't use Post-build events ( <Target Name="PostBuildEventBeforeDllExport" BeforeTargets="DllExportMod">
<Exec Command="..." ContinueOnError="true" />
</Target> etc. |
* NEW: The new lightweight manager & distribution via MvsSln & GetNuTool projects. Issue #38. Based on hMSBuild logic and includes GetNuTool core. Now you shouldn't use standard nuget clients anymore: https://www.youtube.com/watch?v=okPThdWDZMM Package from nuget.org already contains this, but you can also get it directly. Latest version: https://raw.githubusercontent.com/3F/DllExport/latest/manager/DllExport.bat ~18 Kb text-based embeddable batch-scripts that does not require powershell and dotnet-cli. To install/uninstall or to reconfigure your projects: `DllExport -action Configure` To manually restore package: `DllExport -action Restore` All available features: `DllExport -h` Server by default - nuget.org * NEW: The new Wizard (configurator via MvsSln). To easy configure your projects in any place. Issue #38. MvsSln v1.0.1.43422: https://github.com/3F/MvsSln * NEW: Added support of global namespaces - Issue #47. Use `Direct-Mod` if Cecil will not process this correctly. * FIXED: Fixed target platform detection. Issue #34. Details: #34 (comment) * FIXED: Fixed problem when the Post-Build event is triggered before our tool. Issue #35. Use this if still is needed: ``` <Target Name="PostBuildEventBeforeDllExport" BeforeTargets="DllExportMod"> ... </Target> ``` * FIXED: Fixed generation of exp + .lib via MS Library Manager for VS2017. Issue #37. Now it also includes processing through VsDevCmd & VcVarsAll initializer scripts. Use the folowing msbuild properties to override values by default: * $(DllExportVcVarsAll); $(DllExportVsDevCmd) * FIXED: Fixes possible problem with multiple properties that contains *Undefined* word, e.g.: *Undefined*\path1;C:\path2 ... * CHANGED: Added information about finding lib tool. Issue #44. * CHANGED: UI. Selected platform now affects to all configurations of project instead of active as before. * CHANGED: Now, nuget package does not contain library in `lib/.../` Details in #36. * CHANGED: Now, we also distribute .zip package for work through our manager etc. https://github.com/3F/DllExport/releases The latest text-based manager you can find here: https://raw.githubusercontent.com/3F/DllExport/latest/manager/DllExport.bat Illustration here: https://www.youtube.com/watch?v=okPThdWDZMM
* NEW: The new embeddable lightweight manager for distribution via MvsSln & GetNuTool projects. Issue #38. Based on hMSBuild logic and includes GetNuTool core v1.6.1. Now you shouldn't use standard nuget clients anymore: https://www.youtube.com/watch?v=9bYgywZ9pPE Quick start: https://www.youtube.com/watch?v=sBWt-KdQtoc ============================== DllExport -action Configure ============================== Package from nuget.org already contains manager, but you can also get it directly. Latest manager: https://3F.github.io/DllExport/releases/latest/manager/ ~18 Kb text-based embeddable batch-script that does not require powershell and dotnet-cli. Automatic restoring still is available but you can also use: `DllExport -action Restore` All available features: `DllExport -h` Direct links to remote package (without nuget server) via `-pkg-link {uri}` key. Issue #53. NuGet Server by default: nuget.org. * NEW: The new Wizard (configurator via MvsSln). To easy configure your projects in any place. Part of Issue #38. MvsSln v2.0: https://github.com/3F/MvsSln * NEW: Added support of empty/global namespaces - Issue #47. Use `Direct-Mod` if Cecil will not process this correctly. * NEW: Implemented another storage for configuration: '.net.dllexport.targets'. Issue #49. * NEW: New settings for configurator (Wizard): * Path to custom ILAsm. * Flag to keep intermediate Files (IL Code, Resources, ...). * Timeout of execution in milliseconds. * NEW: Implemented automatic checking existence of a correct exported proc via Conari. Issue #55. Wizard controls it via `$(DllExportPeCheck)`: * 0x01 bit - Will check count of all planned exports from final PE32/PE32+ module. * 0x02 bit - Will check existence of all planned exports (IL code) in actual PE32/PE32+ module. * NEW: Implemented PE32/PE32+ Viewer to check manually available exports from final modules. Issue #55. New key for manager: ``` -pe-exp-list {module} - To list all available exports from PE32/PE32+ module. ``` Sample: ``` DllExport -pe-exp-list bin\Debug\regXwild.dll ``` * FIXED: Fixed target platform detection. Issue #34. Details: #34 (comment) * FIXED: Fixed problem when the Post-Build event is triggered before our tool. Issue #35. Use this if still is needed: ``` <Target Name="PostBuildEventBeforeDllExport" BeforeTargets="DllExportMod"> ... </Target> ``` * FIXED: Fixed generation of exp + .lib via MS Library Manager for VS2017. Issue #37. Now it also includes processing through VsDevCmd & VcVarsAll initializer scripts. Use the folowing msbuild properties to override values by default: * $(DllExportVcVarsAll); $(DllExportVsDevCmd) * FIXED: Fixes possible problem with multiple properties that contains *Undefined* word, e.g.: *Undefined*\path1;C:\path2 ... * CHANGED: Added information about finding lib tool. Issue #44. * CHANGED: UI. Selected platform now affects to all configurations of project instead of active as before. * CHANGED: Now nuget package does not contain library in `lib/.../` Details in #36. * CHANGED: Now we also distribute .zip package for work through our manager etc. https://github.com/3F/DllExport/releases * NOTE: How to avoid EXP0014: RunIlAsm. The library manager still cannot be found. https://www.youtube.com/watch?v=zUejJ4vUPGw Related Issue #44 * NOTE: Quick start (Configuring, Automatic restoring, Pe-Viewer): https://www.youtube.com/watch?v=sBWt-KdQtoc * NOTE: The latest text-based manager: https://3F.github.io/DllExport/releases/latest/manager/ Other versions you can find from GitHub Releases: * https://github.com/3F/DllExport/releases Or get it from nuget packages starting with v1.6+ * NOTE: PE-features via Conari v1.3.0 https://github.com/3F/Conari * KNOWN: Bug when - "Build successful but methods are not exported." Issue #59 For today, anyone else may also try to use https://github.com/3F/Conari to avoid similar @Genteure's problem. * DIFF(v1.6-RC): * FIXED: Wizard. Fixed incorrect layout for zh_CN Simplified Chinese (Thanks @Genteure). Issue #61 * FIXED: Fixes automatic restoring the package via msbuild. Issue #62
I have discovered this bug a while ago and I am surprised to see that it is still not fixed.
Note: This bug is specific to DllExport code/package (any version)! Such bug does not exist in UnmanagedExports code/package (v1.2.7).
For example:
Install-Package DllExport
, pick any version, the newest release v1.5.2 is still affected by this bug).COPY /Y "$(TargetPath)" "$(SolutionDir)$(TargetFileName)"
You should have something like this:

Next, build the project and wait for it to complete.
The above simple post-build event should copy the compiled DLL with exports into another directory (overwriting the existing file if it exists).
However, it seems that it instead copies compiled DLL without any exports into another directory.
And like I already said, this is not the case with UnmanagedExports package; post-build event works fine with UnmanagedExports package, apparently this bug has been introduced in DllExport code/package!
To speed things up, you can download my example (DllExport) VS2017 solution from here:
DllExport-PostBuild-issue.zip
And here you can also download another example VS2017 solution which uses UnmanagedExports package instead (to see that post-build works correctly with it):
UnmanagedExports-PostBuild.zip
Please fix DllExport :)
The text was updated successfully, but these errors were encountered: