-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot configure solution that contains a .Net Core project #56
Comments
Thanks for the report. The problem because of new SDK-based format of project files and old MS-logic. That is, this part controlled by MvsSln project, and this exactly from Microsoft.Build.Evaluation-classes. As I understand, today MS don't want to support many incompatible changes (like this 3F/MvsSln#1) at least for .net 4.0... But, this is not a big problem for DllExport project at least for current features :) Before fixes, temporarily try to use this by adding <Project Sdk="Microsoft.NET.Sdk" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
</PropertyGroup>
</Project> |
It now complains about the Remove attribute in element
It also complains about the Version attribute in element Temporarily removing theses attributes, in addition to your suggestion, allows the configuration tool to run, allowing me to add it to both netfx and netcore projects (although the netcore won't build, complaining that it can't find ildasm.exe (using default IL Assembler)). |
well yes, because of obsolete schema.
Can you clarify this part in details ? Currently DllExport still have no official support for .net core projects if you're trying this. But if you have problem for others, please send detailed build log. |
This is on a .Net Core project, when attempting to build, there is an error stating it can't find ildasm.exe The relevant part of the log;
If you want the full log I can also attach it (it's quite long). |
yes, please attach the full detailed log as an additional file using the following command:
|
The Solution has 4 projects The solution file had C++ (Linux) projects, but those where removed to install v1.6.0 (and never readded) |
Something went wrong with your configuration because I see calling
Can you try to reconfigure all this again by removing from all projects (uncheck for all - then apply - then again install for CLR_DEV9.csproj), and also choose '.targets file' storage (.net.dllexport.targets). I still can't reproduce this error even if .net core-based project has dependencies to projects with DllExport modification. In addition, you also may reproduce this structure of projects as an simple demo, then attach for debug. p.s.: please attach anything (including text-based log above) as zip archive etc. still via github attachments. |
The configuration was intentional, I was wanting to see if DllExport export worked with .Net Core projects (It didn't). The solution builds correctly if DllExport is removed from CLR_DEV9_CORE and only configured for CLR_DEV9. I mentioned before that the two projects are effectively the same, CLR_DEV9 is intended for windows users and CLR_DEV9_CORE is the Linux port (hence the need for CoreCLR), the builds are not dependent on each other. If DllExport does not support .NetCore, then I will have to create a wrapper for the .NetCore version of the project. |
Good ! as I expected. Just to be clear for all, again, this repo does not contain support for .net core-based projects today. |
@TheLastRar please check the latest changes - build70 ( 20eb9db ) |
The new bat file failed with
If i use the old bat file, but keep the files in DllExport.1.6.0-beta3 as build70, the configuration tool launches correctly, detecting the Core and C++ projects as unload-able and allows me to configure the framework project (CLR_DEV9). I uninstalled and reinstalled DllExport to check if that works and builds (it does). |
Thanks for the reply ! Seems problem for LF from AppVeyor CI Please check new build71 (same commit) with:
https://ci.appveyor.com/project/3Fs/dllexport/build/build-71 Related issue: 3F/hMSBuild#2 |
Yes that version works correctly |
Good ! v1.6 will be soon. Anyone else, please test latest beta as carefully as possible. |
* FIXED: Avoids crashes when project cannot be loaded for some reasons. Issue #56 * FIXED: Fixed usage of manager outside the Solution directory. * FIXED: Fixed restoring package when using `-pe-exp-list` command. * NEW: Added `-mgr-up` key. Will update manager to version from '-dxp-version'. * NOTE: Thanks for your feedback. Now we're ready for release v1.6, soon. Please check release-candidate as carefully as possible. Start with: ============================== DllExport -action Configure ============================== https://3F.github.io/DllExport/releases/latest/manager/ https://www.youtube.com/watch?v=okPThdWDZMM&t=46s
How to reproduce
Create a solution with a .Net Core library
What version and selected configuration ?
v1.6.0b3
Can you provide detailed log of your build ?
When running DllExport_configure.bat
[03:11:55 PM.9349] [Fatal] ERROR-Wizard: The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the <Project> element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format. D:\Air\Source\Repos\CLR-DEV9\CLR_DEV9\CLR_DEV9_CORE.csproj
The text was updated successfully, but these errors were encountered: