-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrupted data when the compression method 0x08 -> 0x00 / compressed size info [02 00 00 00] #3
Comments
3F
added a commit
that referenced
this issue
Aug 17, 2017
how it should be now:
|
3F
added a commit
that referenced
this issue
Aug 18, 2017
* FIXED: Fixed problem "Input string was not in a correct format" when used version with release type, e.g.: 1.2.3-alpha, 1.2.3-beta-2, 1.2.3-rc ... * FIXED: Avoids errors with possible incorrect CRC & Compressed size info. Issue #3 * FIXED: Fixed problems with paths and whitespace characters for `-unpack` command in executable version. * CHANGED: Removed '15.0' from searching by registry key as an unused way for all new VS2017+ * CHANGED: 'MSBuild was not found' now returns (0x2) ERROR_FILE_NOT_FOUND * CHANGED: Сhanged variable name %msbuild% to %msbuildexe% that was related for Issue #2 * CHANGED: Improved comparing arguments for executable version.
3F
added a commit
to 3F/DllExport
that referenced
this issue
Aug 19, 2017
…problems with possible incorrect CRC & Compressed size info - #38 3F/GetNuTool#3 #38 (comment)
3F
added a commit
to 3F/DllExport
that referenced
this issue
Aug 19, 2017
* NOTE: This release contains trivial fixes only for our manager because of problems with nuget.org. Issue #38. Please read all changes in previous beta release and please note again - you shouldn't use standard nuget clients anymore: https://www.youtube.com/watch?v=okPThdWDZMM Test and comment anything about this in Issue #38 if you need. * FIXED: Updated GetNuTool v1.6.1 to fix problems with possible incorrect CRC & Compressed size info from nuget.org. Changelog here: https://github.com/3F/GetNuTool/blob/master/changelog.txt Related issues: * 3F/GetNuTool#3 * #38 (comment) * CHANGED: Changed url to get latest manager directly. Please use this if you need: * https://3F.github.io/DllExport/releases/latest/manager/ Other versions you can find from GitHub Releases: * https://github.com/3F/DllExport/releases Or get it from nuget packages starting with v1.6+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Possible bug with packages was described here:
3F/DllExport#38 (comment)
GetNuTool processes packages through System.IO.Packaging.ZipPackage and for this data we can't use this at all:
all above will throw exception because of corrupted data and/or incorrect internal processing.
btw:
Through ZipPackage implementation we also have no any information about position from file outside processed part. Or does it available ? o_O
Because for this case we can process this manually:
other header:
that is, from headers above we have information about uncompressed type data, with compressed size == 2, and actual 0 bytes.
specific exception because of incorrect crc:
MS.Internal.IO.Zip.ProgressiveCrcCalculatingStream.Read(Byte[] buffer, Int32 offset, Int32 count)
well, seems try/catch is the most easy way to process this case, because it's bug of the System.IO.Packaging.ZipPackage and from nuget.org. Details here: 3F/DllExport#38
Any suggestions are welcome.
The text was updated successfully, but these errors were encountered: