Add config to choose binary vs human-readable, for Serializer and Deserializer #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2020
chpio
reviewed
Sep 12, 2020
…erializer Add a defaulted type parameter to `Deserializer` and all its auxiliary types, threading the config ZSTs through. Delegate `Serializer::is_human_readable` and `Deserializer::is_human_readable` to the config. Test round-tripping for the new config variants this introduces.
joshtriplett
force-pushed
the
inhuman
branch
from
dd96764 to
605ecd5
Compare
|
Very nice. Thank you. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a defaulted type parameter to
Deserializerand all its auxiliarytypes, threading the config ZSTs through. Delegate
Serializer::is_human_readableandDeserializer::is_human_readabletothe config. Test round-tripping for the new config variants this
introduces.