Improve the deserializer compile time #350
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that using
rmp_serde
to deserialize large structs has a considerable effect on the compile time. It also has twice the impact of comparable crates likeserde_json
when generating deserialization code.The solution here is to take as much code as possible out of generic methods that are instantiated for each type. This reduces the LLVM IR lines from 3652241 to 3238664 (-11.3%) and the time to compile
rmp_serde::from_slice::<MyBigStruct>(&[])
from 52s to 33s (-36%). For reference, doing the same withserde_json
takes about 25s to compile.Here are the LLVM stats of the worst offenders before and after the changes.
any_inner
is still pretty high up and with some more elbow grease it might be possible to reduce it more, but I don't feel comfortable going any further in this PR.before
after