remove boolean flip to prevent it being negated twice #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this moves the boolean change into the else case, because when you call selectAll() with isAllSelected = true right now, it will then call clearSelected, which is fine. However, inside that method, the isAllSelected boolean will get set to false already, once its done and the flow goes back to the selectAll(), we can see that after if/else the boolean is flipped again causing the selectAll to not work once all have been selected
to reproduce the error try the following:
In playground: