Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(kt-table): remove $on call from KtTable #969

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

Isokaeder
Copy link
Collaborator

after a thorough investigation this code turned out to be unused and safe to remove

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Jul 17, 2024
@Isokaeder Isokaeder force-pushed the remove-dollar-on-from-kt-table branch from afc3661 to e48b0d9 Compare July 17, 2024 13:21
after a thorough investigation this code turned out to be unused and safe to remove
@Isokaeder Isokaeder force-pushed the remove-dollar-on-from-kt-table branch from e48b0d9 to a6d9dd2 Compare July 17, 2024 13:22
Copy link
Member

@FlorianWendelborn FlorianWendelborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Isokaeder Isokaeder merged commit b3ee2bf into master Jul 17, 2024
9 checks passed
@Isokaeder Isokaeder deleted the remove-dollar-on-from-kt-table branch July 17, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:kotti-ui @3yourmind/kotti-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants