Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(element-ui): externalize translations #973

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

Isokaeder
Copy link
Collaborator

create helper function to handle eventual default keys when importing element-ui's translation objects

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Jul 23, 2024
@Isokaeder Isokaeder force-pushed the load-languages-lazily branch from 101895b to 5e35046 Compare July 23, 2024 07:56
@Isokaeder Isokaeder changed the title fix(element-ui): don't externalize translations fix(element-ui): externalize translations Jul 23, 2024
Copy link
Member

@FlorianWendelborn FlorianWendelborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

create helper function to handle eventual default keys when importing element-ui's translation objects
@Isokaeder Isokaeder force-pushed the load-languages-lazily branch from 5e35046 to 2d3d100 Compare July 23, 2024 09:24
@Isokaeder Isokaeder enabled auto-merge July 23, 2024 09:25
@Isokaeder Isokaeder merged commit 9747b14 into master Jul 23, 2024
9 checks passed
@Isokaeder Isokaeder deleted the load-languages-lazily branch July 23, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:kotti-ui @3yourmind/kotti-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants