Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(kt-accordion): add snapshot test #984

Merged
merged 1 commit into from
Aug 10, 2024
Merged

test(kt-accordion): add snapshot test #984

merged 1 commit into from
Aug 10, 2024

Conversation

santiagoballadares
Copy link
Collaborator

No description provided.

@santiagoballadares santiagoballadares self-assigned this Aug 7, 2024
@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Aug 7, 2024
FlorianWendelborn
FlorianWendelborn approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@FlorianWendelborn FlorianWendelborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm a bit worried about those data attributes changing. Let's see

@FlorianWendelborn FlorianWendelborn merged commit 5536433 into master Aug 10, 2024
10 checks passed
@FlorianWendelborn FlorianWendelborn deleted the kt-accordion-snapshot-test branch August 10, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isokaeder Isokaeder Isokaeder approved these changes

@FlorianWendelborn FlorianWendelborn FlorianWendelborn approved these changes

Assignees

@santiagoballadares santiagoballadares

Labels
package:kotti-ui @3yourmind/kotti-ui type:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santiagoballadares @FlorianWendelborn @Isokaeder