Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video work #1739

Merged
merged 25 commits into from
Feb 13, 2022
Merged

Video work #1739

merged 25 commits into from
Feb 13, 2022

Conversation

3b1b
Copy link
Owner

@3b1b 3b1b commented Feb 13, 2022

Various changes and updates made during the Wordle project

@3b1b
Enable setting points to a null list, and adding one point at a time.
a642591
@3b1b
Add refresh_locked_data
33d2894
@3b1b
Add presenter mode to scenes with -p option
9a9cc8b
@3b1b
Allow for an embed by hitting e during interaction
9df12fc
@3b1b
Add set_min_height, etc.
2798d15
@3b1b
Make sure null parametric curve has at least one point
2488b9e
@3b1b
Account for edge case where \{ is used in Tex
8e9b4d8
@3b1b
Allow for logging notes in wait calls, useful for presenter mode
eab97fa
@3b1b
Simplify choose, and add gen_choose for fractional amounts
872c949
@3b1b
Default to no top on axes
6c6d387
@3b1b
Allow match_x, match_y, etc. to take in a point
29a4d3e
@3b1b
Allow wait calls to ignore presenter mode
ea5036c
@3b1b
Just use math.combo, no caching with choose(n, r)
6376f0a
@3b1b
Use generator instead of list in bezier
eb245f6
@3b1b
Merge branch 'master' of github.com:3b1b/manim into video-work
a33df4a
@3b1b
Merge branch 'master' of github.com:3b1b/manim into video-work
4c96eab
@3b1b
Merge branch 'master' of github.com:3b1b/manim into video-work
a26edf9
@3b1b
Merge branch 'master' of github.com:3b1b/manim into video-work
24f5a50
@3b1b
Merge branch 'master' of github.com:3b1b/manim into video-work
62c7a89
@3b1b
Merge branch 'master' of github.com:3b1b/manim into video-work
10dcb84
@3b1b
Bubble init_colors should override
0f195d6
@3b1b
Account for "px" values read in from an svg
9486209
@3b1b
Stop displaying when writing is happening
58e06e8
@3b1b
Merge branch 'master' of github.com:3b1b/manim into video-work
e09a264
@3b1b
Update the way Bubble override SVG colors
28403c0
@3b1b 3b1b merged commit 6028097 into master Feb 13, 2022
@TonyCrane
Copy link
Collaborator

I noticed that you still use "Squash and merge" method to merge this pull request. But this is equivalent to creating a new commit in the master branch, and cannot eliminate these new commits in the video-work branch.
So every time you submit a pull request from video-work to the master branch, although the files will not be changed repeatedly, these commits will still appear, just like #1740.
The most effective way is to delete the video-work branch, and then create a new video-work branch based on the master branch :)

@3b1b
Copy link
Owner Author

3b1b commented Feb 14, 2022

Right you are my apologies there.

@TonyCrane TonyCrane mentioned this pull request Feb 14, 2022
Closed
TonyCrane added a commit that referenced this pull request Feb 14, 2022
@TonyCrane
docs: update changelog for #1725 #1727 #1728 #1731 #1739 #1740
fc1e916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3b1b @TonyCrane