Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML and ASCII parser improvements for reading data from String/Reader #71

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

jpstotz
Copy link
Contributor

@jpstotz jpstotz commented Sep 8, 2022

There were no possibility to directly parse an XML or ASCII plist form a String or Reader instance.

Furthermore minor improvements to PropertyListParser were made (e.g. reading a file should not use block size lower than 4K as this is inefficient, 4K is the default block size of most file systems).

Using the constants form StandardCharsets instead of custom Strings saves the charset name parsing.

@3breadt 3breadt merged commit d4367cd into 3breadt:master Sep 17, 2022
@3breadt
Copy link
Owner

3breadt commented Sep 17, 2022

Thanks for the contribution 👍

@jpstotz jpstotz deleted the dev branch September 17, 2022 10:46
@Alllsworld72
Copy link

Alllsworld72 commented Oct 17, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants